Skip to content

Conversation

@kaizencc
Copy link
Contributor

Follow up to #631. #631 (comment)

an exit code of 1 should not map to an event failure, so the refactor command is incorrectly implemented.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jul 23, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team July 23, 2025 18:16
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.29%. Comparing base (edef43c) to head (e2960d4).

Files with missing lines Patch % Lines
packages/aws-cdk/lib/cli/cdk-toolkit.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
- Coverage   81.34%   81.29%   -0.05%     
==========================================
  Files          63       63              
  Lines        8320     8320              
  Branches      967      961       -6     
==========================================
- Hits         6768     6764       -4     
- Misses       1526     1531       +5     
+ Partials       26       25       -1     
Flag Coverage Δ
suite.unit 81.29% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kaizencc kaizencc changed the title chore(refactor): refactor command throws error on failure chore(cli): refactor command throws error on failure Aug 5, 2025
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Aug 5, 2025
Merged via the queue into main with commit 2877f4c Aug 5, 2025
27 checks passed
@aws-cdk-automation aws-cdk-automation deleted the conroy/refactor branch August 5, 2025 15:27
iankhou pushed a commit that referenced this pull request Aug 21, 2025
Follow up to #631.
#631 (comment)

an exit code of 1 should not map to an event failure, so the refactor
command is incorrectly implemented.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants