Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Mar 19, 2025

This adds in the code for @aws-cdk/integ-runner, which is being removed from the original aws-cdk repository here: aws/aws-cdk#33835

Process:

  • The removal PR should be merged first
  • Then this should be merged
  • Then we need to find the latest released version and add a tag named @aws-cdk/[email protected] (or whatever the latest version is) on the parent commit of this commit.

This proposed to drop the -alpha release tag of this package, which seems fine. We've been running this for years, it hasn't changed much, and future updates will be easier to consume if we drop the prerelease tags.

(Stacked PR on top of #246)


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 19, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 19, 2025 18:17
@rix0rrr rix0rrr changed the base branch from main to huijbers/exact-deps March 19, 2025 18:17
@rix0rrr rix0rrr force-pushed the huijbers/exact-deps branch from a792b5c to 6a01f80 Compare March 19, 2025 18:18
@rix0rrr rix0rrr changed the title chore: move integ-runner over feat: @aws-cdk/integ-runner now lives in the CDK CLI repository Mar 19, 2025
@rix0rrr rix0rrr added the pr/exempt-integ-test Skips the integ test steps if set. label Mar 19, 2025
@rix0rrr rix0rrr force-pushed the huijbers/integ-runner branch 4 times, most recently from d38e11c to 8dfe74e Compare March 20, 2025 08:33
@rix0rrr rix0rrr force-pushed the huijbers/exact-deps branch 3 times, most recently from f9df8bf to 4ea903f Compare March 20, 2025 09:50
@rix0rrr rix0rrr force-pushed the huijbers/integ-runner branch 2 times, most recently from fc147a3 to 63f9b1a Compare March 20, 2025 10:49
Base automatically changed from huijbers/exact-deps to main March 20, 2025 12:00
@rix0rrr rix0rrr marked this pull request as ready for review March 20, 2025 12:46
mergify bot pushed a commit to aws/aws-cdk that referenced this pull request Mar 20, 2025
This removes `@aws-cdk/integ-runner` and `@aws-cdk/cdk-cli-wrapper` from this repository into the CLI repository. The other PR adding the new package is here: aws/aws-cdk-cli#263.

This code belongs more with the CLI than it does with the construct library.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
rix0rrr and others added 3 commits March 20, 2025 14:41
Monorepo dependencies were using carets `^`; for most of these it
didn't matter because the resulting artifact was bundled anyway,
but for a couple it did matter:

* `cdk -> aws-cdk`: should use the exact same version, otherwise
  running `npx [email protected]` may accidentally execute `[email protected]`.
Signed-off-by: github-actions <[email protected]>
@rix0rrr rix0rrr force-pushed the huijbers/integ-runner branch from 55bbef7 to 515243f Compare March 20, 2025 13:42
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit d66e375 Mar 20, 2025
10 of 11 checks passed
@aws-cdk-automation aws-cdk-automation deleted the huijbers/integ-runner branch March 20, 2025 14:27
hwum pushed a commit to hwum/aws-cdk that referenced this pull request Mar 21, 2025
This removes `@aws-cdk/integ-runner` and `@aws-cdk/cdk-cli-wrapper` from this repository into the CLI repository. The other PR adding the new package is here: aws/aws-cdk-cli#263.

This code belongs more with the CLI than it does with the construct library.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
shikha372 pushed a commit to shikha372/aws-cdk that referenced this pull request Apr 4, 2025
This removes `@aws-cdk/integ-runner` and `@aws-cdk/cdk-cli-wrapper` from this repository into the CLI repository. The other PR adding the new package is here: aws/aws-cdk-cli#263.

This code belongs more with the CLI than it does with the construct library.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants