Skip to content

fix: replace poetry installation with bash for github actions #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

fix: replace poetry installation with bash for github actions #903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/autoscaling_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@ jobs:
java-version: 8

- name: Install poetry
uses: abatilo/actions-poetry@v3
with:
poetry-version: '1.8.2'
shell: bash
run: |
pipx install poetry==1.8.2
poetry config virtualenvs.prefer-active-python true

- name: Install dependencies
run: poetry install
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/draft_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,11 @@ jobs:
uses: actions/setup-python@v4
with:
python-version: '3.11'
- name: 'Install poetry'
uses: abatilo/actions-poetry@v2
with:
poetry-version: '1.8.2'
- name: Install poetry
shell: bash
run: |
pipx install poetry==1.8.2
poetry config virtualenvs.prefer-active-python true
- name: 'Install dependencies'
run: poetry install
- name: 'Run mypy - static type checking'
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,10 @@ jobs:
java-version: 8

- name: Install poetry
uses: abatilo/actions-poetry@v3
with:
poetry-version: '1.8.2'
shell: bash
run: |
pipx install poetry==1.8.2
poetry config virtualenvs.prefer-active-python true

- name: Install dependencies
run: poetry install
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/integration_tests_codebuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,10 @@ jobs:
java-version: 8

- name: Install poetry
uses: abatilo/actions-poetry@v3
with:
poetry-version: '1.8.2'
shell: bash
run: |
pipx install poetry==1.8.2
poetry config virtualenvs.prefer-active-python true

- name: Install dependencies
run: poetry install
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,10 @@ jobs:
with:
python-version: ${{ matrix.python-version }}
- name: Install poetry
uses: abatilo/actions-poetry@v3
with:
poetry-version: ${{ matrix.poetry-version }}
shell: bash
run: |
Copy link
Contributor Author

@JuanLeee JuanLeee Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why Use |?

Clarity: Even for a single command, using | makes it clear that the value is a multi-line string (and it’s a common convention in GitHub Actions).

Flexibility: If you later add more commands, you can do so without changing the YAML structure. For example:

pipx install poetry==${{matrix.poetry-version}}
poetry config virtualenvs.prefer-active-python true
Copy link
Contributor Author

@JuanLeee JuanLeee Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not using the current python version installed causing all tests to run on python 3.12

Copy link
Contributor

@karenc-bq karenc-bq Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this comment directly to the workflow file for context

- name: Install dependencies
run: poetry install
- name: Run mypy - static type checking
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/mysql_performance_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@ jobs:
java-version: 8

- name: Install poetry
uses: abatilo/actions-poetry@v2
with:
poetry-version: '1.8.2'
shell: bash
run: |
pipx install poetry==1.8.2
poetry config virtualenvs.prefer-active-python true

- name: Install dependencies
run: poetry install
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/pg_performance_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@ jobs:
java-version: 8

- name: Install poetry
uses: abatilo/actions-poetry@v3
with:
poetry-version: '1.8.2'
shell: bash
run: |
pipx install poetry==1.8.2
poetry config virtualenvs.prefer-active-python true

- name: Install dependencies
run: poetry install
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,11 @@ jobs:
uses: actions/setup-python@v4
with:
python-version: '3.11'
- name: 'Install poetry'
uses: abatilo/actions-poetry@v2
with:
poetry-version: '1.4.2'
- name: Install poetry
shell: bash
run: |
pipx install poetry==1.8.2
poetry config virtualenvs.prefer-active-python true
- name: 'Install dependencies'
run: poetry install
- name: 'Create a Package'
Expand Down