fix: remove unneccesary boto3 call to verify region #1042
Merged
+10
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faviansamatha
force-pushed
the
fix/remove-boto3-region-verification
branch
from
d690543 to
524c2db
Compare
sophia-bq
reviewed
Nov 21, 2025
faviansamatha
force-pushed
the
fix/remove-boto3-region-verification
branch
from
524c2db to
47835e8
Compare
sophia-bq
approved these changes
Nov 24, 2025
faviansamatha
force-pushed
the
fix/remove-boto3-region-verification
branch
from
47835e8 to
d056877
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, when we parse the iam_region parameter in the authentication plugins, we verify it with boto3 as a fail-fast validation check. However, as pointed out by #1041 would cause performance issues as we would call this function every time we connect.
This commit removes that check. The invalid region error will be returned from the aws call by boto3 instead.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.