Don't get connection for closed statement #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
thx for the PR! |
jliuhtonen
force-pushed
the
topic/check-statements-not-closed
branch
from
1560b70 to
3e6c6f8
Compare
Contributor
Author
|
I fixed the checkstyleTest failure by amending the previous commit to avoid separate "fix imports" commit. The problem was static wildcard import caused by IDE automatic imports. Thanks! |
karenc-bq
approved these changes
Oct 13, 2023
It is possible that .getConnectionFromSqlObject() is called for a statement that has already been closed. This is the case when e.g. calling .isClosed() for a closed Statement. In this case, an SQLException is thrown from statement.getConnection() unnecessarily. The exception might also be detected in various APM product instrumentations leading to false positive errors.
jliuhtonen
force-pushed
the
topic/check-statements-not-closed
branch
from
3e6c6f8 to
935fa9b
Compare
Contributor
Author
|
Rebased with latest changes from main. |
Contributor
Author
|
Hi @karenc-bq, would it be possible to rerun the tests on CI? They pass for me locally and I suspect that could there be a timing issue in |
Contributor
|
Thank you for catching and fixing the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Don't attempt to get connection for closed Statement
Description
It is possible that .getConnectionFromSqlObject() is called for a statement that has already been closed. This is the case when e.g. calling .isClosed() for a closed Statement. In this case, an SQLException is thrown from statement.getConnection() unnecessarily. The exception might also be detected in various APM tool instrumentations leading to false positive errors.
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.