fix: IAM_DEFAULT_PORT property to override host and dialect ports. #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiyvamz
reviewed
Jun 2, 2023
| IamAuthConnectionPlugin.useCachedIamToken=Use cached IAM token = ''{0}'' | ||
| IamAuthConnectionPlugin.generatedNewIamToken=Generated new IAM token = ''{0}'' | ||
| IamAuthConnectionPlugin.invalidPort=Port number: {0} is not valid. Port number should be greater than zero. | ||
| IamAuthConnectionPlugin.invalidPort=Port number: {0} is not valid. Port number should be greater than zero. Falling back to host or dialect port. |
Contributor
There was a problem hiding this comment.
Falling back to default port.
?
Contributor
Author
There was a problem hiding this comment.
Just changed the messaging to "...Falling back to default port."
sergiyvamz
approved these changes
Jun 2, 2023
crystall-bitquill
approved these changes
Jun 3, 2023
aaronchung-bitquill
force-pushed
the
bugfix/issue-473-iam-default-port
branch
from
a8ee4cf to
7360843
Compare
karenc-bq
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix in the IamAuthConnectionPlugin to prioritize the override property IAM_DEFAULT_PORT then Hosts port, and then Dialect port.
Description
Fix in the IamAuthConnectionPlugin to prioritize the override property IAM_DEFAULT_PORT then Hosts port, and then Dialect port.
This also results in change of behaviour. When an invalid port value is specified for IAM_DEFAULT_PORT, it no longer throws an exception, but rather logs a warning and then falls back on either the Host port or Dialect default port.
Additional Reviewers
@sergiyv-improving @karenc-bq @aaron-congo @crystall-bitquill
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.