Skip to content

fix: checkstyle and properties being overridden #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karenc-bq merged 1 commit into from
May 30, 2023
Merged

fix: checkstyle and properties being overridden #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/checkstyle/checkstyle-suppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,5 @@
<suppress files="[\\/]MysqlConnectorJDataSourceHelper\.java" checks="IllegalImport"/>
<suppress files="[\\/]PgDataSourceHelper\.java" checks="IllegalImport"/>
<suppress files="[\\/]test[\\/]" checks="IllegalImport"/>
<suppress files="[\\/]ExtendedFormatter\.java" checks="Header"/>
</suppressions>
3 changes: 2 additions & 1 deletion wrapper/src/main/java/software/amazon/jdbc/DriverConnectionProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,9 @@ public Connection connect(
final @NonNull Properties props)
throws SQLException {

final Properties copy = PropertyUtils.copyProperties(props);
final ConnectInfo connectInfo =
this.targetDriverDialect.prepareConnectInfo(protocol, hostSpec, props);
this.targetDriverDialect.prepareConnectInfo(protocol, hostSpec, copy);

LOGGER.finest(() -> "Connecting to " + connectInfo.url
+ PropertyUtils.logProperties(connectInfo.props, "\nwith properties: \n"));
Expand Down