Update CHANGELOG for 2.1.0 #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md
Outdated
|
|
||
| ## [2.1.0] - 2023-5-11 | ||
| ### :magic_wand: Added | ||
| - Added checks to ensure stale writer records obtained after writer-failover, are used ([PR #435](https://github.com/awslabs/aws-advanced-jdbc-wrapper/pull/435)). |
Contributor
There was a problem hiding this comment.
Suggested change
| - Added checks to ensure stale writer records obtained after writer-failover, are used ([PR #435](https://github.com/awslabs/aws-advanced-jdbc-wrapper/pull/435)). | |
| - Added checks to ensure stale writer records obtained after writer-failover, are not used ([PR #435](https://github.com/awslabs/aws-advanced-jdbc-wrapper/pull/435)). |
Contributor
Author
There was a problem hiding this comment.
Oh gosh....🤦
Thank you for catching that.
Fix pushed!
aaronchung-bitquill
force-pushed
the
changelog-2.1.0
branch
from
3287926 to
dc3f12e
Compare
karenc-bq
reviewed
May 12, 2023
CHANGELOG.md
Outdated
| - Added checks to ensure stale writer records obtained after writer-failover, are not used ([PR #435](https://github.com/awslabs/aws-advanced-jdbc-wrapper/pull/435)). | ||
|
|
||
| ### :bug: Fixed | ||
| - Fixed connection state transfer bug where switching from read-only connection to writer connection, incorrectly triggers the failover process ([Issue #426](https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/426)). |
Contributor
There was a problem hiding this comment.
Suggested change
| - Fixed connection state transfer bug where switching from read-only connection to writer connection, incorrectly triggers the failover process ([Issue #426](https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/426)). | |
| - Fixed connection state transfer bug where switching from read-only connection to writer connection incorrectly triggers the failover process ([Issue #426](https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/426)). |
aaronchung-bitquill
force-pushed
the
changelog-2.1.0
branch
from
dc3f12e to
dbcc00d
Compare
karenc-bq
reviewed
May 12, 2023
CHANGELOG.md
Outdated
| - Removed logic that changes connection to a writer instance when `setReadOnly(false)` is called on a reader connection ([Issue #426](https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/426)). | ||
| - Improved internal connection pool key defaults ([PR #432](https://github.com/awslabs/aws-advanced-jdbc-wrapper/pull/432)). | ||
| - Removed Multi-writer cluster related code as they are no longer supported ([PR #435](https://github.com/awslabs/aws-advanced-jdbc-wrapper/pull/435)). | ||
| - Clarify documentation on failover process to account for Aurora PostgerSQL clusters being offline during failover ([PR #437](https://github.com/awslabs/aws-advanced-jdbc-wrapper/pull/437)). |
Contributor
There was a problem hiding this comment.
Suggested change
| - Clarify documentation on failover process to account for Aurora PostgerSQL clusters being offline during failover ([PR #437](https://github.com/awslabs/aws-advanced-jdbc-wrapper/pull/437)). | |
| - Clarified documentation on failover process to account for Aurora PostgerSQL clusters being offline during failover ([PR #437](https://github.com/awslabs/aws-advanced-jdbc-wrapper/pull/437)). |
aaronchung-bitquill
force-pushed
the
changelog-2.1.0
branch
4 times, most recently
from
4568415 to
bd601d2
Compare
karenc-bq
reviewed
May 12, 2023
CHANGELOG.md
Outdated
| - `AuroraHostListProvider` to check for stale writer records obtained after writer-failover so that they are not used ([PR #435](https://github.com/awslabs/aws-advanced-jdbc-wrapper/pull/435)). | ||
|
|
||
| ### :bug: Fixed | ||
| - Resolved a potential security concern by ensuring that user specific connections in the connection pool are returned to the correct user ([PR #432](https://github.com/awslabs/aws-advanced-jdbc-wrapper/pull/432)). |
Contributor
There was a problem hiding this comment.
Suggested change
| - Resolved a potential security concern by ensuring that user specific connections in the connection pool are returned to the correct user ([PR #432](https://github.com/awslabs/aws-advanced-jdbc-wrapper/pull/432)). | |
| - A potential security concern by ensuring that user specific connections in the connection pool are returned to the correct user ([PR #432](https://github.com/awslabs/aws-advanced-jdbc-wrapper/pull/432)). |
hsuamz
approved these changes
May 12, 2023
aaronchung-bitquill
force-pushed
the
changelog-2.1.0
branch
from
bd601d2 to
e939bc0
Compare
aaronchung-bitquill
force-pushed
the
changelog-2.1.0
branch
from
e939bc0 to
f061167
Compare
karenc-bq
approved these changes
May 12, 2023
congoamz
reviewed
May 12, 2023
|
|
||
| ## [2.1.0] - 2023-5-11 | ||
| ### :magic_wand: Added | ||
| - `AuroraHostListProvider` to check for stale writer records obtained after writer-failover so that they are not used ([PR #435](https://github.com/awslabs/aws-advanced-jdbc-wrapper/pull/435)). |
Contributor
There was a problem hiding this comment.
might rephrase slightly, it sounds a bit like AuroraHostListProvider is a new class we added with the way its currently phrased.
AuroraHostListProvider checks for stale writer records after writer failover so that they are not used (PR #435)
| ### :bug: Fixed | ||
| - Potential security concern by ensuring that user specific connections in the connection pool are returned to the correct user ([PR #432](https://github.com/awslabs/aws-advanced-jdbc-wrapper/pull/432)). | ||
| - Connection state transfer bug where switching from read-only connection to writer connection incorrectly triggers the failover process ([Issue #426](https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/426)). | ||
| - Incorrect invalidation of newly promoted writer and random readers after failover. EFM plugin to use instance endpoint as the monitoring endpoint in the case the initial connection is established using cluster endpoint ([PR #431](https://github.com/awslabs/aws-advanced-jdbc-wrapper/pull/431)). |
Contributor
There was a problem hiding this comment.
nit: ...monitoring endpoint in case the...
| - Temporarily set socket timeout for the topology query if it is not set, to avoid topology query from executing indefinitely ([PR #416](https://github.com/awslabs/aws-advanced-jdbc-wrapper/pull/416)). | ||
|
|
||
| ### :crab: Changed | ||
| - Removed logic that changes connection to a writer instance when `setReadOnly(false)` is called on a reader connection ([Issue #426](https://github.com/awslabs/aws-advanced-jdbc-wrapper/issues/426)). |
Contributor
There was a problem hiding this comment.
Removed logic from the failover plugin that changes connection to a writer instance when setReadOnly(false) is called on a reader connection (Issue #426). This functionality already exists in the read write splitting plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
Additional Reviewers
@karenc-bq @congoamz @sergiyv-improving
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.