chore: refactoring pg sql queries to be fully qualified #1561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiyvamz
changed the title
aaron-congo
reviewed
Oct 15, 2025
wrapper/src/test/java/integration/container/tests/metrics/DatabasePerformanceMetricTest.java
Show resolved
Hide resolved
Contributor
|
Need to also update a call to aurora_limitless_router_endpoints in our messages.properties file |
aaron-congo
reviewed
Oct 16, 2025
wrapper/src/main/java/software/amazon/jdbc/dialect/RdsMultiAzDbClusterPgDialect.java
Show resolved
Hide resolved
Contributor
|
Do any of the following need to be prefixed by "pg_catalog" as well? Some of these appear to be in pg_catalog but I'm not sure if they need it
|
aaron-congo
reviewed
Oct 16, 2025
examples/AWSDriverExample/src/main/java/software/amazon/TelemetryMetricsOTLPExample.java
Outdated
Show resolved
Hide resolved
examples/AWSDriverExample/src/main/java/software/amazon/TelemetryTracingXRayExample.java
Outdated
Show resolved
Hide resolved
Contributor
Author
It wasn't planned. Some of those functions are built-in so requires no pg_catalog. |
sergiyvamz
force-pushed
the
fix-qualify-queries
branch
from
69137f8 to
f67c8f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
chore: refactoring pg sql queries to be fully qualified
Additional Reviewers
@karenc-bq
@aaron-congo
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.