fix: isValidTimeout potentially rounded down to 0 #1546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiyvamz
reviewed
Oct 1, 2025
wrapper/src/main/java/software/amazon/jdbc/plugin/efm2/HostMonitorImpl.java
Outdated
Show resolved
Hide resolved
sergiyvamz
approved these changes
Oct 1, 2025
sergiyvamz
force-pushed
the
fix/isValid-zero
branch
from
d43b211 to
a4626b4
Compare
sergiyvamz
force-pushed
the
fix/isValid-zero
branch
from
a4626b4 to
b92d620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
isValidTimeoutcould potentially rounded down, causing the monitoring connections to send a isValid request without any timeout.Description
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.