Skip to content

refactor: decouple dependencies and clean up initialization logic #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 79 commits into from
Oct 14, 2025
Merged

refactor: decouple dependencies and clean up initialization logic #1541

merged 79 commits into from
Oct 14, 2025

Conversation

@aaron-congo
Copy link
Contributor

@aaron-congo aaron-congo commented Sep 26, 2025 •
edited
Loading

  • before this refactor, the ConnectionWrapper and ConnectionPluginManager classes both depended on each other, and the PluginServiceImpl and ConnectionPluginManager classes also depended on each other. This PR removes the ConnectionPluginManager's dependencies on the ConnectionWrapper and PluginService
  • also cleans up initialization logic by performing service container setup in the ServiceUtility class. This class can be used to either create service containers for client connections or for more limited ("minimal") monitor use

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aaron-congo
wip
b94b7f2
@aaron-congo
Replace PluginService#forceConnect with ConnectionService#open in Clu…
29a58cb 
…sterAwareWriterFailoverHandler
@aaron-congo
Add notes for how to fix the current issues
f59930d
@aaron-congo
Integ test passing
8fc6d1a
@aaron-congo
Pass ConnectionService to ReaderFailoverHandler
b4e5b3a
@aaron-congo
Adapted ReaderFailoverHandler, IT passing
a2342be
@aaron-congo
Merge branch 'main' into failover-handlers
cedbc1b
@aaron-congo
Add hostAvailabilityMap to WriterFailoverResult
8108551
@aaron-congo
Add hostAvailabilityMap to ReaderFailoverResult
0a38ab3
@aaron-congo
Initialize HostListProvider in PartialPluginService constructor
1a7e2bc
@aaron-congo
Pass ConnectionService as constructor arg to failover handlers
a965c3f
@aaron-congo
PR suggestions
a3d8a5e
@aaron-congo
Fix checkstyle
4df33da
@aaron-congo
ReaderFailoverHandler tests passing
7a863c9
@aaron-congo
WriterFailoverHandler tests passing
370d73f
@aaron-congo
FailoverConnectionPluginTests passing
435f71a
@aaron-congo
Merge branch 'main' into failover-handlers
7ba0f85
@aaron-congo
Rename plugin to spyPlugin in FailoverConnectionPluginTest
6ebf706
@aaron-congo
Fix failing MonitorServiceImplTest tests
7711a9e
@aaron-congo
Fix failover1 integration test
9928517
@aaron-congo
testServerFailoverWithIdleConnections uses the correct failover plugin
6a338f2
@aaron-congo
Merge branch 'main' into failover-handlers
367b6a5
@aaron-congo
Fix javadocs
faa0915
@aaron-congo
wip
23e177a
@aaron-congo
Add extra logging to debug IT failure
e1af3eb
@aaron-congo
Fix bug where cached reader connection was incorrectly closed
c077ee2
@aaron-congo
Merge branch 'main' into failover-handlers
a27cf9f
@aaron-congo
wip
73cf143
@aaron-congo
Fix javadoc
99de6eb
@aaron-congo
Merge branch 'failover-handlers' into service-container-utility
f1eb529
@aaron-congo
Revert "Rename ServicesContainer to ServiceContainer"
74d22c9 
This reverts commit b5f5649.
@aaron-congo
Reuse service containers for reader failover ConnectionAttemptTasks
6311d63
@aaron-congo
Get build working
577ed48
@aaron-congo
Remove pluginService reference in ConnectionPluginManager
a0cc0c7
@aaron-congo
wip
27fc533
@aaron-congo
Remove ConnectionWrapper dependency from ConnectionPluginManager wip
4d984f5
@aaron-congo
Pass ConnectionWrapper to Wrapper objects wip
d50ae1e
@aaron-congo
Pass ConnectionWrapper to Wrapper objects, building
9364003
@aaron-congo
ConnectionPluginManager#init -> ConnectionPluginManager#initPlugins
7a11cdd
@aaron-congo
Build passing after uncommenting unit tests
8d3eef3
@aaron-congo
Check for old connection in WrapperUtils#executeWithPlugins
dc36daa
@aaron-congo
Fix unit tests
7528368
@aaron-congo
Merge branch 'main' into init-cleanup
dcc261a
@aaron-congo
gradlew check passing
7365a37
@aaron-congo
Set initial host list provider
20eb07e
@aaron-congo
Add missing initHostProvider call
fc6f278
@aaron-congo
Integration test passing
55c4e33
@aaron-congo aaron-congo merged commit 6ae2d9a into main Oct 14, 2025
6 checks passed
@aaron-congo aaron-congo deleted the init-cleanup branch October 14, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergiyvamz sergiyvamz sergiyvamz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aaron-congo @sergiyvamz