perf: avoid creating monitor plugin chains when unnecessary #1530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sterAwareWriterFailoverHandler
…new plugin services
sergiyvamz
approved these changes
Sep 12, 2025
aaron-congo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1522
Before this change, we created a new plugin chain every time MonitorServiceImpl#runIfAbsent was called. Since this method is called often, this was leading to performance impacts. After these changes, we will only create the new plugin chain when it is actually required (when the monitor does not already exist).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.