Skip to content

fix: LimitlessRouterMonitor to close connection properly #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

fix: LimitlessRouterMonitor to close connection properly #1369

merged 1 commit into from
Apr 24, 2025
+70 −41

Conversation

@aaronchung-bitquill
Copy link
Contributor

@aaronchung-bitquill aaronchung-bitquill commented Apr 23, 2025 •
edited
Loading

Summary

Fix connection leak issue due to Limitless Plugin not properly closing off monitoring connections

Description

  • Now doing check and close on monitor conns when monitor close is called and in finally block of monitor run
  • Added an outer try catch finally and moved some of the exception catching there

Additional Reviewers

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aaronchung-bitquill aaronchung-bitquill force-pushed the fix/limitless-conn-leak branch 4 times, most recently from a580942 to 4f67a4c Compare April 23, 2025 23:40
@aaronchung-bitquill aaronchung-bitquill marked this pull request as ready for review April 23, 2025 23:53
@aaronchung-bitquill aaronchung-bitquill merged commit 4a50f17 into aws:main Apr 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergiyvamz sergiyvamz sergiyvamz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aaronchung-bitquill @sergiyvamz