Skip to content

Use singleton for null telemetry objects in NullTelemetryFactory #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergiyvamz merged 2 commits into from
Nov 13, 2024
Merged

Use singleton for null telemetry objects in NullTelemetryFactory #1188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1daff23
Refactor NullTelemetryFactory to use singleton instances for null tel…
johnou Nov 12, 2024
3d3e4c0
Merge branch 'main' into singleton-null-telemetry
johnou Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions wrapper/src/main/java/software/amazon/jdbc/util/telemetry/NullTelemetryFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,13 @@

public class NullTelemetryFactory implements TelemetryFactory {

private static final TelemetryContext NULL_TELEMETRY_CONTEXT = new NullTelemetryContext("null");
private static final TelemetryCounter NULL_TELEMETRY_COUNTER = new NullTelemetryCounter("null");
private static final TelemetryGauge NULL_TELEMETRY_GAUGE = new NullTelemetryGauge("null");

@Override
public TelemetryContext openTelemetryContext(String name, TelemetryTraceLevel traceLevel) {
return new NullTelemetryContext(name);
return NULL_TELEMETRY_CONTEXT;
}

@Override
Expand All @@ -30,11 +34,11 @@ public void postCopy(TelemetryContext telemetryContext, TelemetryTraceLevel trac

@Override
public TelemetryCounter createCounter(String name) {
return new NullTelemetryCounter(name);
return NULL_TELEMETRY_COUNTER;
}

@Override
public TelemetryGauge createGauge(String name, GaugeCallable<Long> callback) {
return new NullTelemetryGauge(name);
return NULL_TELEMETRY_GAUGE;
}
}
Loading