Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gracefully terminate on SIGTERM #211

Merged
merged 1 commit into from
Feb 29, 2024
Merged

gracefully terminate on SIGTERM #211

merged 1 commit into from
Feb 29, 2024

Conversation

kmala
Copy link
Contributor

@kmala kmala commented Feb 21, 2024

Issue #, if available:

Description of changes:
Currently the pod identity container wouldn't exit on SIGTERM because metricsServer is not handling the signal and would only exit on SIGKILL. Adding signal handling to the metric server also such that server is gracefully shutdown on SIGTERM

We can now see the graceful shutdown log after the change

I0221 21:37:52.906702      11 reflector.go:377] k8s.io/client-go/informers/factory.go:159: forcing resync
I0221 21:38:42.900211      11 file_watcher.go:91] context closed, stopping FileWatcher
I0221 21:38:42.900305      11 main.go:319] Graceflully closed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kmala kmala requested a review from a team as a code owner February 21, 2024 21:51
@nnmin-aws
Copy link
Contributor

/lgtm

1 similar comment
@nnmin-aws
Copy link
Contributor

/lgtm

@nnmin-aws
Copy link
Contributor

LGTM!

@kmala kmala merged commit 703c8e7 into aws:master Feb 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants