Ability to set use_http_client_to_fetch_aws_credentials#65
Merged
suniltheta merged 2 commits intoaws:mainfrom Dec 12, 2023
Merged
Ability to set use_http_client_to_fetch_aws_credentials#65suniltheta merged 2 commits intoaws:mainfrom
suniltheta merged 2 commits intoaws:mainfrom
Conversation
joesbigidea
approved these changes
Dec 8, 2023
liubnu
approved these changes
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include this change only on v1.29.x, v1.30.x Envoy release. Or on v1.28.x if upstream commits on Envoy release v1.29 are ported back.
From v1.31.x onwards this feature flag is going to be removed.
Summary
Ability to set
envoy.reloadable_features.use_http_client_to_fetch_aws_credentials, which defaults tofalse.Following the changes in Envoy to deprecated libcurl, we introduced a reloadable feature flag to control whether to enable or disable the new technique of fetching the aws credentials via http async client.
For now this is default disabled and will be enabled by default in a follow up PR in the repo with a workaround to make usage of http async client work for AppMesh users.
See envoyproxy/envoy#30731, envoyproxy/envoy#31135, https://docs.google.com/document/d/1m1KE_LGDnxrXwnUC1OEKYLmw8szy4r06OX_O3JcM-wM
Testing
New tests cover the changes: yes
Description for the changelog
Option to set
envoy.reloadable_features.use_http_client_to_fetch_aws_credentialsvia env variable.Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.