Add option to override reloadable_features.sanitize_original_path#15
Merged
karanvasnani merged 1 commit intoaws:mainfrom Apr 7, 2023
Merged
Conversation
liubnu
approved these changes
Apr 7, 2023
karanvasnani
approved these changes
Apr 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add option to override
envoy reloadable_features.sanitize_original_pathif needed via env variableENVOY_SANITIZE_ORIGINAL_PATH. By default this will be true. Allowed values aretrueorfalse.Testing
make testNew tests cover the changes: yes
Description for the changelog
Expose option to override the default value of
reloadable_features.sanitize_original_pathviaENVOY_SANITIZE_ORIGINAL_PATHenvironment variable. Default is true.Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.