This repository has been archived by the owner on Sep 13, 2024. It is now read-only.
add 'none' logging driver to ECS Agent's config #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhaynes
approved these changes
Oct 30, 2017
richardpen
approved these changes
Oct 30, 2017
ecs-init/docker/docker_test.go
Outdated
| @@ -224,7 +224,8 @@ func validateCommonCreateContainerOptions(opts godocker.CreateContainerOptions, | |||
| expectKey("ECS_AGENT_CONFIG_FILE_PATH="+config.AgentJSONConfigFile(), envVariables, t) | |||
| expectKey("ECS_UPDATE_DOWNLOAD_DIR="+config.CacheDirectory(), envVariables, t) | |||
| expectKey("ECS_UPDATES_ENABLED=true", envVariables, t) | |||
| expectKey(`ECS_AVAILABLE_LOGGING_DRIVERS=["json-file","syslog","awslogs"]`, envVariables, t) | |||
| expectKey(`ECS_AVAILABLE_LOGGING_DRIVERS=["json-file","syslog","awslogs","none"]`, | |||
| envVariables, t) | |||
This commit modifies the `ECS_AVAILABLE_LOGGING_DRIVERS` env var for the Agent to include `none` logging driver. This compliments aws/amazon-ecs-agent#1041 PR in the ECS Agent repository.
aaithal
force-pushed
the
registerNoneLoggingDriverOnStart
branch
from
e452100 to
30ee220
Compare
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit modifies the
ECS_AVAILABLE_LOGGING_DRIVERSenv varfor the Agent to include
nonelogging driver. This complimentsaws/amazon-ecs-agent#1041 PR in the
ECS Agent repository.
Testing Done
Changelog entry