Skip to content
This repository has been archived by the owner on Sep 13, 2024. It is now read-only.

ubuntu trusty: Updated to Go 1.7 #100

Closed

Conversation

rickard-von-essen
Copy link
Contributor

@rickard-von-essen rickard-von-essen commented Jun 9, 2017

Also bumped version to 1.4.2-2

Requires PPA version of Go since 1.6 is the latest for Trusty. For example this. Go 1.X packages from The Go Language Gophers” team.

@samuelkarp
Copy link
Contributor

Thanks for sending this! We'll want to hold off on merging this until after #101 and v1.14.3 of the agent is released (so it'd also make sense to update this to 1.14.3 and skip 1.14.2.). For more about why we're getting 1.14.3 out quickly, see aws/amazon-ecs-agent#833.

Any reason you'd lean toward this PPA over this one? If we're requiring a PPA to build, it'd probably be good to add that to the docs somewhere and to the debian/changelog file.

@rickard-von-essen
Copy link
Contributor Author

rickard-von-essen commented Jun 12, 2017

Any reason you'd lean toward this PPA over this one?

No just sloppy searching. Updated OP.

requiring a PPA to build, it'd probably be good to add that to the docs

I'll add a note. DONE

I'll updated this as soon as v1.14.3 is out.

@nmeyerhans
Copy link
Contributor

Although we're not by any means bound by (or generally in compliance with) the Debian policy, it'd be nice for changelog to actually be an actual log rather than the stub we have here.

Additionally I'd prefer to see the Golang 1.7 PPA requirement documented in README.source and not just in the changelog. It'll improve discoverability for people who may just be getting started trying to build this package.

@rickard-von-essen
Copy link
Contributor Author

it'd be nice for changelog to actually be an actual log rather than the stub we have here.

Agree. My hope when I refurbished @samuelkarp's initial PR to add Ubuntu Trusty packaging was that AWS would publish (unofficial) packages for this and release it at the same time as those for Amazon Linux.

@rickard-von-essen
Copy link
Contributor Author

It would be nice if you would provide builds for Ubuntu Trusty. Since that is to my knowledge the only other major server distro using upstart still, until its end of life April 2019.

@rickard-von-essen
Copy link
Contributor Author

Updated for 1.14.3-1 and added README.source.

Copy link
Contributor

@nmeyerhans nmeyerhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And yes, I agree that we should provide builds for more distros. No promises about when we might do such a thing, though.

@nmeyerhans
Copy link
Contributor

Merged this into the dev branch. It'll be included in future releases.

@nmeyerhans nmeyerhans closed this Jun 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants