Add comment explaining why ecs-bridge needs a static MAC address #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubhattacharjya
approved these changes
Jun 1, 2023
sparrc
approved these changes
Jun 1, 2023
sparrc
added a commit
to sparrc/amazon-ecs-agent
that referenced
this pull request
Jun 2, 2023
This pulls in a fix for an error that can occur when using awsvpc networking mode where a stale MAC address can cause temporary loss of network connectivity in a container. Pulls in the following PRs with the fix and comments: aws/amazon-ecs-cni-plugins#111 aws/amazon-ecs-cni-plugins#112
sparrc
added a commit
to sparrc/amazon-ecs-agent
that referenced
this pull request
Jun 2, 2023
This pulls in a fix for an error that can occur when using awsvpc networking mode where a stale MAC address can cause temporary loss of network connectivity in a container. Pulls in the following PRs with the fix and comments: aws/amazon-ecs-cni-plugins#111 aws/amazon-ecs-cni-plugins#112
sparrc
added a commit
to aws/amazon-ecs-agent
that referenced
this pull request
Jun 5, 2023
This pulls in a fix for an error that can occur when using awsvpc networking mode where a stale MAC address can cause temporary loss of network connectivity in a container. Pulls in the following PRs with the fix and comments: aws/amazon-ecs-cni-plugins#111 aws/amazon-ecs-cni-plugins#112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a comment explaining why ecs-bridge needs a static MAC address.
Implementation details
Just a comment.
Testing
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.