ecs_client/model, functional_tests: updated model, functional tests for adding and dropping Linux capabilities #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaithal
reviewed
Aug 31, 2017
|
@aaithal Not very particularly. Just had it that way since they(cap-add/cap-drop) are separate flags in docker run. Would you prefer it the other way? |
|
If we could model it in the same task def, that would be better as it'd reduce the boot strapping overhead for a new test. |
|
Code looks good. Can you rebase and resolve conflicts? |
sharanyad
force-pushed
the
capadddrop
branch
from
8671599 to
7356faf
Compare
samuelkarp
approved these changes
Sep 19, 2017
|
@sharanyad I think we can merge this whenever you're ready. |
sharanyad
force-pushed
the
capadddrop
branch
from
7356faf to
93a8816
Compare
|
Updated the API and documentation for the new structures. Let's merge once the builds pass. |
…or adding and dropping Linux capabilities
The changes include the following:
- Model changes in ContainerDefinition of the form:
linuxParameters: {
capabilities: {
add: [""],
drop: [""]
}
}
- Functional Tests that verify if the specified capability has been added to and dropped from the task's container
sharanyad
force-pushed
the
capadddrop
branch
from
93a8816 to
e8be5fc
Compare
|
Updated API and Docs to the latest version. |
sharanyad
force-pushed
the
capadddrop
branch
from
e8be5fc to
b61365c
Compare
…mentation, change agent version required
sharanyad
force-pushed
the
capadddrop
branch
from
b61365c to
152a49c
Compare
|
All builds and tests pass |
sharanyad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Model changes to Container Definition for enabling capadd and capdrop for Linux containers.
Functional tests
TODO:
Implementation details
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes: yes
Description for the changelog
Licensing
This contribution is under the terms of the Apache 2.0 License: yes