[WIP] Container Metadata #913

huerdong · 2017-08-04T14:06:57Z

Summary

Adds the Container Metadata feature to the agent, exposing the metadata from ECS and from Docker to agent managed containers, such as the container's DockerID and the Container Instance ARN, and then exposes this metadata for users to access from within the container.

Implementation details

See #848

Testing

Builds on Linux (make release)
Builds on Windows (go build -out amazon-ecs-agent.exe ./agent)
Unit tests on Linux (make test) pass
Unit tests on Windows (go test -timeout=25s ./agent/...) pass
Integration tests on Linux (make run-integ-tests) pass
Integration tests on Windows (.\scripts\run-integ-tests.ps1) pass
Functional tests on Linux (make run-functional-tests) pass
Functional tests on Windows (.\scripts\run-functional-tests.ps1) pass

New tests cover the changes: Yes

Description for the changelog

Feature - Add metadata service for ECS-created containers.

Licensing

This contribution is under the terms of the Apache 2.0 License: Yes

sharanyad · 2017-08-04T14:45:52Z

Shouldn't this be merged into dev instead of master?

vsiddharth · 2017-08-04T15:41:47Z

@huerdong please change the base branch

huerdong · 2017-08-04T15:47:55Z

I fixed the branch problem.

samuelkarp · 2017-08-04T16:59:19Z

You'll need to change the base branch before we can review this. Right now, this pull request shows commits that are already merged into the dev branch from different authors; it's not practical to review that mix of commits.

vsiddharth · 2017-08-07T16:32:02Z

@huerdong Please update the summary block and check the appropriate boxes.
Please double check the license attribution too.

Thanks

aaithal · 2017-08-07T16:33:20Z

agent/containermetadata/metadata_manager.go

+
+	err = os.MkdirAll(metadataDirectoryPath, os.ModePerm)
+	if err != nil {
+		return err


Please add more context for this error. At the very least something like fmt.Errorf("creating metadata directory: %v", err).

aaithal · 2017-08-07T16:34:27Z

agent/containermetadata/metadata_manager.go

+	// Create metadata file
+	err = createMetadataFile(metadataDirectoryPath)
+	if err != nil {
+		return err


Same as above. This error needs context. You can even use errors.Wrapf() from https://github.com/pkg/errors

aaithal · 2017-08-07T16:37:30Z

agent/containermetadata/parse_metadata.go

+// configuration and data then packages it for JSON Marshaling
+// Since we accept incomplete metadata fields, we should not return
+// errors here and handle them at this or the above stage.
+func (manager *metadataManager) parseMetadata(dockerContainer *docker.Container, task *api.Task, container *api.Container) Metadata {


It seems like all you need here are task's arn and container's name. Can you just pass those instead of task and container?

aaithal · 2017-08-07T16:40:01Z

agent/containermetadata/parse_metadata.go

+// Since we accept incomplete metadata fields, we should not return
+// errors here and handle them at this or the above stage.
+func (manager *metadataManager) parseMetadata(dockerContainer *docker.Container, task *api.Task, container *api.Container) Metadata {
+	taskMD := parseTaskMetadata(task, container)


Along the same lines, I don't see the value of creating a function which just initializes a struct. It would be lot helpful to anyone who reads the code to just do this instead:
return Metadata { taskMetadata: TaskMetadata{...} ...}

aaithal · 2017-08-07T16:42:08Z

agent/containermetadata/types.go

+type Network struct {
+	NetworkMode string `json:"NetworkMode,omitempty"`
+	IPv4Address string `json:"IPv4Address,omitempty"`
+}


Please add the IPv6Address field here as well with omitempty. You don't need to do anything for it right now. But, it'll be useful when "Task ENIs" is enabled.

aaithal · 2017-08-07T16:44:14Z

agent/containermetadata/write_metadata.go

+// files of a given task
+func getTaskMetadataDir(task *api.Task, dataDir string) (string, error) {
+	taskID, err := getTaskIDfromARN(task.Arn)
+	return filepath.Join(dataDir, metadataJoinSuffix, taskID), err


You need to deal with err here.

aaithal · 2017-08-07T16:46:22Z

agent/containermetadata/write_metadata_unix.go

+		return err
+	}
+	defer temp.Close()
+	if err != nil {


This is redundant

aaithal · 2017-08-07T16:47:28Z

agent/containermetadata/write_metadata.go

+
+const (
+	metadataJoinSuffix = "metadata"
+	metadataFile       = "metadata.json"


How about "ecs-container-metadata.json" ?

aaithal · 2017-08-07T16:48:37Z

agent/engine/docker_task_engine.go

+	if engine.cfg.ContainerMetadataEnabled {
+		err := engine.metadataManager.CleanTaskMetadata(task)
+		if err != nil {
+			seelog.Errorf("clean task metadata failed for task %s: %v", task, err)


Logs need to start with Upper case letters.

vsiddharth

Changes look much better than before

vsiddharth · 2017-08-07T16:33:22Z

README.md

@@ -175,6 +175,8 @@ configure them as something other than the defaults.
 | `ECS_IMAGE_MINIMUM_CLEANUP_AGE` | 30m | The minimum time interval between when an image is pulled and when it can be considered for automated image cleanup. | 1h | 1h |
 | `ECS_NUM_IMAGES_DELETE_PER_CYCLE` | 5 | The maximum number of images to delete in a single automated image cleanup cycle. If set to less than 1, the value is ignored. | 5 | 5 |
 | `ECS_INSTANCE_ATTRIBUTES` | `{"stack": "prod"}` | These attributes take effect only during initial registration. After the agent has joined an ECS cluster, use the PutAttributes API action to add additional attributes. For more information, see [Amazon ECS Container Agent Configuration](http://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-agent-config.html) in the Amazon ECS Developer Guide.| `{}` | `{}` |
+| `ECS_ENABLE_CONTAINER_METADATA` | `<true|false>` | Whether to enable creation of a metadata file in the container | `false` | `false` |


Please update this line with more information

vsiddharth · 2017-08-07T16:33:49Z

README.md

@@ -175,6 +175,8 @@ configure them as something other than the defaults.
 | `ECS_IMAGE_MINIMUM_CLEANUP_AGE` | 30m | The minimum time interval between when an image is pulled and when it can be considered for automated image cleanup. | 1h | 1h |
 | `ECS_NUM_IMAGES_DELETE_PER_CYCLE` | 5 | The maximum number of images to delete in a single automated image cleanup cycle. If set to less than 1, the value is ignored. | 5 | 5 |
 | `ECS_INSTANCE_ATTRIBUTES` | `{"stack": "prod"}` | These attributes take effect only during initial registration. After the agent has joined an ECS cluster, use the PutAttributes API action to add additional attributes. For more information, see [Amazon ECS Container Agent Configuration](http://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-agent-config.html) in the Amazon ECS Developer Guide.| `{}` | `{}` |
+| `ECS_ENABLE_CONTAINER_METADATA` | `<true|false>` | Whether to enable creation of a metadata file in the container | `false` | `false` |
+| `ECS_HOST_DATA_DIR` | `/var/lib/ecs` | The source directory on the host from which ECS_DATADIR is mounted | `/var/lib/ecs` | `Not used` |


Update this line too

Could you please add information on why this is not used for Windows?

vsiddharth · 2017-08-07T16:42:30Z

agent/containermetadata/metadata_manager.go

+
+// metadataManager implements the MetadataManager interface
+type metadataManager struct {
+	client               dockerMetadataClient


I'd like to see some comments here for each attribute

vsiddharth · 2017-08-07T16:49:20Z

agent/containermetadata/parse_metadata.go

+		cluster:              manager.cluster,
+		taskMetadata:         taskMD,
+		containerInstanceARN: manager.containerInstanceARN,
+		metadataStatus:       "NOT_READY",


Could we have a new type for metadata status ?
I'd like to have it be one amongst a set of well defined values

vsiddharth · 2017-08-07T16:54:26Z

agent/containermetadata/write_metadata_unix.go

+	if err != nil {
+		return fmt.Errorf("write to metadata file for task %s container %s: %v", task, container, err)
+	}
+	metadataFilePath := filepath.Join(metadataFileDir, metadataFile)


This seems to be duplicated code from the createMetadataFile method

vsiddharth · 2017-08-07T16:55:43Z

agent/containermetadata/write_metadata_windows.go

+	ContainerMetadataClientVersion = dockerclient.Version_1_24
+)
+
+// createMetadataFile initializes the metadata file


Update this comment

vsiddharth · 2017-08-07T16:58:23Z

agent/containermetadata/write_metadata_windows.go

+func createMetadataFile(metadataDirectoryPath string) error {
+	metadataFilePath := filepath.Join(metadataDirectoryPath, metadataFile)
+	file, err := os.Create(metadataFilePath)
+	if err != nil {


Why didn't you go with the "Tempfile" approach here ?

aaithal · 2017-08-07T22:20:50Z

agent/app/agent.go

@@ -108,6 +110,26 @@ func newAgent(
 		return nil, err
 	}

+	var metadataManager containermetadata.MetadataManager


containermetadata.Manager stutters less than containermetadata.MetadataManager

I understand your purpose but I am reluctant to make this change because there are so many structs in the agent with the word Manager in them. Having a single struct called Manager, even if preceded by package containermetadata, feels confusing to me.

That's fine. As long as variables are named correctly, it shouldn't matter what the struct name is.

aaithal · 2017-08-07T22:21:14Z

agent/app/agent.go

@@ -108,6 +110,26 @@ func newAgent(
 		return nil, err
 	}

+	var metadataManager containermetadata.MetadataManager
+	if cfg.ContainerMetadataEnabled {
+		// Get the oldest Docker Client version with up to date inspect API


Please move this to a method. Also, this needs a test in agent/app/agent_test.go

Right now I am cautious about making changes here because I have encountered in the past import cycles and/or "interface is not implemented" errors when dealing with this section of code. I will see what I can do here.

I don't see how moving this to a method would result in import cycles. On the other hand, moving this to a method improves readability and makes it more testable.

Do you mean moving it into a method but still within the app package? Maybe I misconstrued your request.

Do you mean moving it into a method but still within the app package?

Yeah.

aaithal · 2017-08-07T22:23:05Z

agent/config/config.go

@@ -315,6 +315,9 @@ func environmentConfig() (Config, error) {
 		seelog.Debugf("Setting instance attribute %v: %v", attributeKey, attributeValue)
 	}

+	containerMetadataEnabled := utils.ParseBool(os.Getenv("ECS_ENABLE_CONTAINER_METADATA"), false)


needs a test

For this and the "needs a test" comments below for the config package, I have added tests to check for my new configuration variables.

aaithal · 2017-08-07T22:23:19Z

agent/config/config_unix.go

@@ -28,6 +28,7 @@ func DefaultConfig() Config {
 		ReservedPorts:               []uint16{SSHPort, DockerReservedPort, DockerReservedSSLPort, AgentIntrospectionPort, AgentCredentialsPort},
 		ReservedPortsUDP:            []uint16{},
 		DataDir:                     "/data/",
+		DataDirOnHost:               "/var/lib/ecs",


needs a test

aaithal · 2017-08-07T22:23:23Z

agent/config/config_windows.go

@@ -44,6 +44,7 @@ const (
 func DefaultConfig() Config {
 	programData := utils.DefaultIfBlank(os.Getenv("ProgramData"), `C:\ProgramData`)
 	ecsRoot := filepath.Join(programData, "Amazon", "ECS")
+	dataDir := filepath.Join(ecsRoot, "data")


needs a test

aaithal · 2017-08-07T22:39:36Z

agent/containermetadata/types.go

+
+// MetadataSerializer is an intermediate struct that converts the information
+// in Metadata into information to encode into JSOn
+type MetadataSerializer struct {


Can this not be global scoped (metadataSerializer )?

aaithal · 2017-08-07T22:40:10Z

agent/containermetadata/write_metadata.go

+// getTaskMetadataDir acquires the directory with all of the metadata
+// files of a given task
+func getTaskMetadataDir(task *api.Task, dataDir string) (string, error) {
+	taskID, err := getTaskIDfromARN(task.Arn)


You need handle this error (points to a lack of unit test).

aaithal · 2017-08-07T22:42:07Z

agent/containermetadata/metadata_manager.go

+// operations
+type MetadataManager interface {
+	SetContainerInstanceARN(string)
+	CreateMetadata(*docker.Config, *docker.HostConfig, *api.Task, *api.Container) error


You can name this as Create instead.

aaithal · 2017-08-07T22:42:17Z

agent/containermetadata/metadata_manager.go

+type MetadataManager interface {
+	SetContainerInstanceARN(string)
+	CreateMetadata(*docker.Config, *docker.HostConfig, *api.Task, *api.Container) error
+	UpdateMetadata(string, *api.Task, *api.Container) error


You can name this as Update instead.

aaithal · 2017-08-07T22:42:36Z

agent/containermetadata/metadata_manager.go

+	SetContainerInstanceARN(string)
+	CreateMetadata(*docker.Config, *docker.HostConfig, *api.Task, *api.Container) error
+	UpdateMetadata(string, *api.Task, *api.Container) error
+	CleanTaskMetadata(*api.Task) error


You can name this as Clean instead.

aaithal · 2017-08-07T22:47:10Z

@huerdong can you also paste the output of go test -cover ./agent/containermetadata? You may need to make some modifications with the command. I'm mostly looking for test coverage data.

vsiddharth · 2017-08-08T17:00:04Z

@huerdong Could you also resolve the conflicts when you update #913 ?

samuelkarp · 2017-08-08T17:10:42Z

agent/app/agent.go

+		// Get the oldest Docker Client version with up to date inspect API
+		// as some metadata is unavailable in older API client versions
+		// If this version is unavailable we use default
+		// Due to limitations of interfaces and import cycles


I think your only import cycle issue is with the containermetadata.ContainerMetadataClientVersion. I'd be in favor of moving this into the client/factory code directly and just moving the constant over there as well so you don't have an import cycle; that'll keep the impact localized to just the code that needs to be refactored anyway.

I'm not quite sure what you mean here. The problem I am encountering is that adding the WithVersion function to the internal dockerMetadataClient interface in the containermetadata package led to "interface not implemented" errors in the past. I am very uncertain about this section of code as a result, but I will try to see if I can minimize the exposure in this section.

samuelkarp · 2017-08-08T17:11:38Z

agent/app/agent.go

+	if cfg.ContainerMetadataEnabled {
+		// Get the oldest Docker Client version with up to date inspect API
+		// as some metadata is unavailable in older API client versions
+		// If this version is unavailable we use default


It'd be reasonable to just disable the feature if Docker is too old.

The feature still works for older versions of docker. The differences in the versions do not actually matter previously because I get the relevant networking metadata through an alternative route for older versions. With the ENI feature added, this difference is significant because older versions of Docker API won't display the additional network modes. Again, I am not very familiar with ENI project except that I was asked to make the Network information into a list to support multiple network modes. I would think if a user wants to use this feature even with an older version of Docker, we should not disable it if it works for that older client.

samuelkarp · 2017-08-08T17:16:58Z

agent/containermetadata/parse_metadata.go

+// configuration and data then packages it for JSON Marshaling
+// Since we accept incomplete metadata fields, we should not return
+// errors here and handle them at this or the above stage.
+func (manager *metadataManager) parseMetadata(dockerContainer *docker.Container, taskARN string, containerName string) Metadata {


Generally, I'd like to see the functions in a file organized with caller-above-callee so that you start with abstractions at a high level and get deeper into details as you read further in the file. That would mean that the entrypoints (parseMetadata and parseMetadataAtContainerCreate) are at the top, then parseDockerContainerMetadata, and last parseNetworkMetadata.

I have made this reorganization.

samuelkarp · 2017-08-08T17:20:29Z

agent/containermetadata/write_metadata_windows.go

+
+	file, err := os.OpenFile(metadataFileName, os.O_WRONLY, 644)
+	if err != nil {
+		// Retry if file does not exist


It's worth checking what this err is before blindly retrying.

samuelkarp · 2017-08-08T17:25:43Z

agent/engine/docker_task_engine.go

+	dockerContainerMD := client.StartContainer(dockerContainer.DockerID, startContainerTimeout)
+
+	// Get metadata through container inspection and available task information then write this to the metadata file
+	// Performs this in the background to avoid delaying container start


It almost feels like this should be a new container state. As is, if the agent restarts while this goroutine is running (after the container has started and we've recorded that in the state file, but before we've completed updating the metadata), you may never get metadata properly updated (startContainer won't be called again).

I think I previously discussed making this a separate container state with @aaithal. Given the timeline of my ability to work on this project, I do not think I can feasibly make this change right now.

This could definite happen in the agent, to make it simple than adding a new state is to add a new state in the container struct to indicate the metadata state.

I have added a TODO here for adding a metadata file status in api.Container and for doing metadata updates for containers running after agent restart.

sharanyad · 2017-08-08T18:05:42Z

agent/containermetadata/write_metadata.go

@@ -0,0 +1,65 @@
+// Copyright 2017 Amazon.com, Inc. or its affiliates. All Rights Reserved.


Why is this file named 'write_metadata.go'? This does not really write metadata as such.

Most of my writing operations was originally here and has since been moved to other places. It is probably better to name it utils.go

sharanyad · 2017-08-08T18:19:04Z

Having some unit tests for metadata manager would be good.

petderek · 2017-08-08T18:31:58Z

Why do we need INITIAL, READY, NOT_READY, etc? As a user, do I care about the state of the metadata?

aaithal · 2017-08-08T18:34:41Z

@petderek it'd have been better if you had just added to the threaded discussion than a comment here. Regardless, as a user, I'd care as it'd help me distinguish between "will i ever get this data" and "i'll eventually get this data if i keep polling"

richardpen · 2017-08-08T18:51:25Z

agent/app/agent.go

+				break
+			}
+		}
+		metadataManager = containermetadata.NewMetadataManager(metadataDockerClient, cfg)


So the default client will be used if ContainerMetadataClientVersion wasn't found, should we disable this feature or shut down the agent instead of providing partial information in the metadata file?

The only missing metadata is in the network settings with the old client. However because we have specific checks in the parsing of the networking metadata to address this issue we will not actually be missing any information unless there are multiple network modes present.

If we handle old clients, do we even care about the client version anymore? Should we just use the default client and get rid of this logic entirely?

The client version matters because with Task ENI multiple network interfaces are now supported. The default client does not give information on additional networks which is only available in v1.21.

@richardpen and @aaithal can correct me here, but I don't believe that docker inspect will return information about the network interfaces added through a CNI plugin.

but I don't believe that docker inspect will return information about the network interfaces added through a CNI plugin

That's correct. It's also worth nothing that we invoke 2 top level CNI plugins and each of them results in a network interface being added to the container (in effect, being part of multiple "network"s)

In that case, I will remove the 1.21 client check and use the default. I will leave the Networks field in the metadata stored as a list in case we use a newer API version as a default later.

richardpen · 2017-08-08T19:14:10Z

agent/engine/docker_task_engine.go

+	dockerContainerMD := client.StartContainer(dockerContainer.DockerID, startContainerTimeout)
+
+	// Get metadata through container inspection and available task information then write this to the metadata file
+	// Performs this in the background to avoid delaying container start


This could definite happen in the agent, to make it simple than adding a new state is to add a new state in the container struct to indicate the metadata state.

richardpen · 2017-08-08T19:51:57Z

agent/engine/docker_task_engine.go

@@ -597,6 +610,15 @@ func (engine *DockerTaskEngine) createContainer(task *api.Task, container *api.C
 	seelog.Infof("Created container name mapping for task %s - %s -> %s", task, container, containerName)
 	engine.saver.ForceSave()

+	// Create metadata directory and file then populate it with common metadata of all containers of this task


Looks like the changes in this file are not unit tested.

I have added unit tests for the docker_task_engine_test.go for the cases where metadata service is enabled.

richardpen · 2017-08-08T19:54:56Z

agent/engine/docker_task_engine.go

@@ -303,6 +308,14 @@ func (engine *DockerTaskEngine) sweepTask(task *api.Task) {
 			seelog.Errorf("Error removing container reference from image state: %v", err)
 		}
 	}
+
+	// Clean metadata directory for task
+	if engine.cfg.ContainerMetadataEnabled {


This check seems weak, as writing the metadata file could fail. The safer way is to add a new state of this file and only delete this file if it's created.

Also please add a debug log here to indicate this happened.

I am not sure why an additional check is needed. If the file is not created, the cleanup would simply do nothing (Not even return an error).
https://golang.org/pkg/os/#RemoveAll

richardpen · 2017-08-08T19:59:13Z

agent/containermetadata/write_metadata_windows.go

+	}
+	metadataFileName := filepath.Join(metadataFileDir, metadataFile)
+
+	file, err := os.OpenFile(metadataFileName, os.O_WRONLY, 644)


can you make 644 a constant, probably move the one defined in write_metadata_unix.go to metadatamanager.go.

huerdong · 2017-08-09T11:30:32Z

I have added unit tests for the containermetadata package, addressing comments by @sharanyad @aaithal.
In addition as requested by @aaithal here is the output of go test -cover ./agent/containermetadata

ok github.com/aws/amazon-ecs-agent/agent/containermetadata 0.012s coverage: 74.5% of statements

Edit: As noted in one of the more recent commits, I have increased this number to 96.2%

aaithal · 2017-08-09T14:35:44Z

@huerdong 74.5% is a relatively low number for a new package that's being written. Please take another look at what code paths are not being covered in tests and add coverage for the same. Here's a blog on how you can generate html reports to visualize the missing test coverage in code: https://blog.golang.org/cover

…e files

…emporary fix to metadata file cleanup

…pport these updates

… version of API. Added tests in config package for new configurations

…nermetadata unit tests to mock os and ioutil calls

…concise. Added TODO in docker_task_engine.go about metadataManager.Update

opalelement · 2017-08-17T14:47:18Z

@aaithal Looks like @huerdong mentioned the code coverage has been bumped to 96.2%

vsiddharth · 2017-08-17T14:52:30Z

@opalelement The code coverage was bumped by @huerdong after we introduced him to using wrappers for mocks.

mariuszluciow · 2017-09-04T15:38:38Z

Hi here, any news on this? We are waiting for #198 quite some time now...

aaithal · 2017-09-18T16:58:14Z

closing this in favor of #981

huerdong closed this Aug 4, 2017

huerdong reopened this Aug 4, 2017

huerdong mentioned this pull request Aug 4, 2017

Container Metadata #848

Closed

8 tasks

huerdong changed the base branch from master to dev August 4, 2017 18:22

huerdong changed the title ~~Container Metadata (Duplicate)~~ Container Metadata Aug 4, 2017

aaithal requested changes Aug 7, 2017

View reviewed changes

vsiddharth suggested changes Aug 7, 2017

View reviewed changes

aaithal reviewed Aug 7, 2017

View reviewed changes

samuelkarp suggested changes Aug 8, 2017

View reviewed changes

sharanyad reviewed Aug 8, 2017

View reviewed changes

richardpen reviewed Aug 8, 2017

View reviewed changes

huerdong added 7 commits August 9, 2017 20:02

Added volume management support in engine and initial metadata servic…

9b1404c

…e files

Fixed volume configuration to mount a host directory.

1ab2131

Fixed write metadata.json issues.

4202cac

Refactored metadataservice and removed unnecessary functions. Added t…

822fef7

…emporary fix to metadata file cleanup

Added metadata file cleanup at container stop

33cdfb5

Implemented metadata file updating. Made additional refactoring to su…

c0d38f8

…pport these updates

Made json format easier to read

9965df4

huerdong added 14 commits August 9, 2017 20:05

Fixed windows build error and removed redundant functions

8dfcda2

Made review changes. Added/fixed metadata fields. Reformatted logging

4c3c3f8

Removed redundant error checks

675d7ef

Undid temp file change for windows

1803430

Fixed build issue with windows

faa5833

Fixed windows metadata file not exist issue

7b37076

Another fix to windows

e78ac9c

Made Update Metadata parallel

df3bf0f

Made changes to remove unnecessary use of pointers

8418abb

Made some review changes. Pushing only to perform validation on windows

e2751fd

Fixed broken mocks

81cb6e3

Added unit tests for containermetadata package

ebc5e6c

Addressed review changes and reverted metadata service to use default…

72df463

… version of API. Added tests in config package for new configurations

Fixed non-compiling integ test

b3c0662

huerdong force-pushed the mdservice branch from 1398bc7 to b3c0662 Compare August 9, 2017 20:40

huerdong added 6 commits August 10, 2017 07:26

Added wrappers for os and ioutil packages for testing. Changed contai…

00663ee

…nermetadata unit tests to mock os and ioutil calls

Increase coverage of containermetadata unit tests to 96.2%

3a024a4

Fixed non-compiling windows tests

9fc1c76

Fixed TestWriteFileWriteFail

e8aa107

Added metadata service enabled unit tests to docker_task_engine_test.go

5f4cb20

Made description of ENABLE_CONTAINER_METADATA and HOST_DATA_DIR more …

16c9df0

…concise. Added TODO in docker_task_engine.go about metadataManager.Update

This was referenced Aug 24, 2017

Discovering host port mapping when host port isn't specified. #198

Closed

A way to link ALB logs to the ECS Task they connected to #940

Closed

adnxn changed the title ~~Container Metadata~~ [WIP] Container Metadata Sep 5, 2017

adnxn mentioned this pull request Sep 12, 2017

metadata service continued #981

Merged

8 tasks

aaithal closed this Sep 18, 2017

		@@ -0,0 +1,65 @@
		// Copyright 2017 Amazon.com, Inc. or its affiliates. All Rights Reserved.

[WIP] Container Metadata #913

[WIP] Container Metadata #913

Conversation

huerdong commented Aug 4, 2017 • edited Loading

Summary

Implementation details

Testing

Description for the changelog

Licensing

sharanyad commented Aug 4, 2017

vsiddharth commented Aug 4, 2017

huerdong commented Aug 4, 2017 • edited Loading

samuelkarp commented Aug 4, 2017

vsiddharth commented Aug 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vsiddharth left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huerdong Aug 8, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aaithal commented Aug 7, 2017

vsiddharth commented Aug 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huerdong Aug 8, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sharanyad commented Aug 8, 2017

petderek commented Aug 8, 2017

aaithal commented Aug 8, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huerdong Aug 9, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huerdong Aug 9, 2017 • edited Loading

huerdong commented Aug 4, 2017 •

edited

Loading

huerdong commented Aug 4, 2017 •

edited

Loading

huerdong Aug 8, 2017 •

edited

Loading

huerdong Aug 8, 2017 •

edited

Loading

aaithal commented Aug 8, 2017 •

edited

Loading

huerdong Aug 9, 2017 •

edited

Loading

huerdong Aug 9, 2017 •

edited

Loading

huerdong Aug 8, 2017 •

edited

Loading