Prevent network-blackhole-port from affecting TMDS access #4403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Network blackhole port fault with
{"Port": 80, "Protocol": "tcp", "TrafficType": "egress"}
configuration currently breaks task's access to TMDS since the fault affects all TCP destinations on port 80 which includes TMDS for the task. This is undesirable as TMDS access is needed to interact with Fault Injection APIs.This PR prevents this issue by adding an additional rule to the fault's iptables chain that accepts all tcp traffic destined for TMDS.
Implementation details
The fault injection handler now appends an additional rule to accept TMDS traffic using the command below.
The fault chain looks like below after the fault has been injected.
Testing
Ran a host mode and awsvpc mode task and then ran the following commands from the task container. The second command below does not work without the changes in this PR.
New tests cover the changes: yes
Description for the changelog
bugfix: Prevent TMDS access from being impacted by network-blackhole-port fault.
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.