Remove unnecessary set driver and instance log level calls #4396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If Agent is not started with a
logLevel
command-line argument then it attempts to set driver and instance log level of the logger usingloglevel-driver
andloglevel-on-instance
command-line arguments regardless of whether they were passed or not. This causes the following misleading error logs to be printed.This PR fixes this issue by making Agent skip setting driver and instance log levels if the corresponding command-line arguments are not passed.
Fixes #4375.
Testing
Ran Agent and verified that the misleading error logs are no longer printed. Log level settings continue to be set and work as before.
New tests cover the changes: no
Description for the changelog
bugfix - Remove unnecessary set driver and instance log level calls
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.