Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary set driver and instance log level calls #4396

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

amogh09
Copy link
Contributor

@amogh09 amogh09 commented Oct 14, 2024

Summary

If Agent is not started with a logLevel command-line argument then it attempts to set driver and instance log level of the logger using loglevel-driver and loglevel-on-instance command-line arguments regardless of whether they were passed or not. This causes the following misleading error logs to be printed.

{"level":"error","time":"2024-10-01T06:24:05Z","msg":"Driver log level mapping not found","module":"log.go"}
{"level":"error","time":"2024-10-01T06:24:05Z","msg":"Instance log level mapping not found","module":"log.go"}

This PR fixes this issue by making Agent skip setting driver and instance log levels if the corresponding command-line arguments are not passed.

Fixes #4375.

Testing

Ran Agent and verified that the misleading error logs are no longer printed. Log level settings continue to be set and work as before.

New tests cover the changes: no

Description for the changelog

bugfix - Remove unnecessary set driver and instance log level calls

Additional Information

Does this PR include breaking model changes? If so, Have you added transformation functions?

Does this PR include the addition of new environment variables in the README?

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@amogh09 amogh09 requested a review from a team as a code owner October 14, 2024 21:19
@amogh09 amogh09 changed the base branch from master to dev October 14, 2024 21:19
@amogh09 amogh09 merged commit 193b771 into aws:dev Oct 18, 2024
40 checks passed
amogh09 added a commit to amogh09/amazon-ecs-agent that referenced this pull request Oct 23, 2024
* Set driver log level and instance log level during startup only when settings are available

* Minor change
@mye956 mye956 mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants