-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cgroupv2 vendor #4350
Update cgroupv2 vendor #4350
Conversation
0aabad1
to
1d5caa8
Compare
@tinnywang @prateekchaudhry what's the path to getting this merged? |
Signed-off-by: Josh Chorlton <[email protected]>
Hi @jchorl, thank you for your contribution! This pull request has been reviewed, approved, and now merged to |
Thank you for helping push it through! |
Summary
Patch version bump of cgroup from
3.0.2
to3.0.4
. Mostly just trying to pick up this fix: containerd/cgroups@9008873Notably, it bumps the timeout for creating cgroup resources from 1s to 30s(!). It also adds some robustness around creating cgroup resources.
I found in my logs:
So I'm optimistic this may help!
There are also many other good fixes in the latest release of cgroups.
Implementation details
Just a vendor bump.
I first got in a container:
Then:
Testing
Ran
make test
locallyNew tests cover the changes: N/A
Description for the changelog
Update agent version of https://github.com/containerd/cgroups from v3.0.2 to v3.0.4
Additional Information
N/A
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.