-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose FaultInjection status in TaskResponse #4285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxx0624
force-pushed
the
fis-agentstate-cr
branch
from
August 14, 2024 23:53
f9a0332
to
acc5e02
Compare
amogh09
reviewed
Aug 15, 2024
amogh09
previously approved these changes
Aug 15, 2024
xxx0624
force-pushed
the
fis-agentstate-cr
branch
from
August 15, 2024 23:07
0d05fe1
to
5e8ed27
Compare
xxx0624
changed the title
Expose FIS status in TaskResponse
Expose FaultInjection status in TaskResponse
Aug 15, 2024
amogh09
approved these changes
Aug 15, 2024
mye956
approved these changes
Aug 16, 2024
danehlim
added a commit
to danehlim/amazon-ecs-agent
that referenced
this pull request
Aug 17, 2024
This reverts commit fd3693c.
harishxr
pushed a commit
that referenced
this pull request
Aug 18, 2024
* Revert "Expose FaultInjection status in TaskResponse (#4285)" This reverts commit fd3693c. * Revert "Implementing network blackhole port handler" This reverts commit 177dbd2. * Revert "TaskStopVerificationACKResponder integration tests (#4282)" This reverts commit d6fbc04. * Revert "Container transition to MANIFEST_PULLED state should happen after network pause container reaches RESOURCES_PROVISIONED state (#4286)" This reverts commit 6c7758d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change is to expose the FaultInjection status to the
TaskResponse
so that GetTaskMetadata in AgentState can facilitate shared Faults handlers to determine if the new endpoints should be exposed to tasks.Implementation details
FaultInjectionEnabled
to the https://github.com/aws/amazon-ecs-agent/blob/master/ecs-agent/tmds/handlers/v4/state/response.go#L32Testing
Launch a task where the TMDS has this change and the new field is not visible in task metadata response
New tests cover the changes:
Yes
Description for the changelog
Feature - add an internal field in TaskResponse object.
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.