Add awslogs-endpoint for isolated regions when creating containers #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekchaudhry
force-pushed
the
cwiso
branch
3 times, most recently
from
d5ab4ad to
8f74c87
Compare
yinyic
approved these changes
Jul 26, 2024
mye956
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes agent add
awslogs-endpointfor all isolated regions whenawslogsdriver is configured for the container.Implementation details
Add all current isolated regions to the current list of regions where agent configures
awslogs-endpointwhen creating containersTesting
Added unit tests for all regions
New tests cover the changes:
Yes
Description for the changelog
Bugfix: Add awslogs-endpoint for isolated regions when creating containers
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.