Refactor non-docker container stats and add unit tests #4200
+51
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a minor followup to #4196
Change NonDockerContainerStats from a pointer to a reference, and change the restartCount field from a reference to a pointer.
What this does is enables the getNonDockerContainerStats function to always return the object, but only return restartCount when it should be set to a non-nil value. This will make NonDockerContainerStats easier to extend in the future, and allows for checking if restartCount is set or not explicitly. We expect this field to not be set (nil) when the feature is not enabled. This allows for explicit testing and checking of three scenarios:
Testing
Unit tests were added to verify exact scenarios when we expect restartCount to be nil, zero, and non-zero.
Description for the changelog
NA
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.