Additional integration tests for digest resolution changes #4161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
force-pushed
the
digest-tests
branch
2 times, most recently
from
da4de5a to
ab40ae3
Compare
amogh09
force-pushed
the
feature/digest-resolution
branch
from
d2ae88e to
ce4bfd3
Compare
amogh09
force-pushed
the
digest-tests
branch
2 times, most recently
from
eabe305 to
54a99e3
Compare
amogh09
changed the title
amogh09
force-pushed
the
feature/digest-resolution
branch
from
ce4bfd3 to
a217454
Compare
hozkaya2000
previously approved these changes
May 9, 2024
prateekchaudhry
approved these changes
May 9, 2024
hozkaya2000
approved these changes
May 9, 2024
amogh09
added a commit
that referenced
this pull request
May 13, 2024
amogh09
added a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a couple of additional integration tests for changes to enable image digest resolution in ECS Agent. The tests are -
TestInvalidImageInteg- tests that a task with a single container that has an invalid image fails with aCannotPullImageManifestErrorerror.TestImageWithDigestInteg- tests that a task with a single container whose image has a valid digest specified works as expected.The PR also includes a change to fix flakiness of
TestManifestPulledDoesNotDependOnContainerOrderingintegration test. The test is flaky because it assumes thatpublic.ecr.aws/docker/library/busybox:1.36.1image is immutable but it's not. The PR also changes the test to use an image from local test registry instead as using a remote image does not affect the test.Some minor refactoring changes and a typo fix is also included in this PR.
Testing
New tests cover the changes: yes
Description for the changelog
Enhancement: Additional integration tests for digest resolution changes
Does this PR include breaking model changes? If so, Have you added transformation functions?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.