Delete containers before the task from BoltDB

[SreeeS]

Summary

At present in removeTaskData we delete the task followed by container/s. In case agent exits after deleting the task before deleting the containers, the DB is left in corrupted state due to which the agent fails to restart with error:

level=critical time=2023-04-23T04:18:49Z msg="Unable to initialize new task engine: failed to load previous data from BoltDB: failed to load task engine state: did not find the task of container <task arn> module=agent.go

The error is triggered here. This change reverses the order of deletion where the container/s are deleted followed by task.

Implementation details

• Update removeTaskData in agent/engine/data.go to first delete container/s followed by task.

Testing

• GitHub workflow
• Manual test for scenario where agent exits after deleting container/s with out deleting task in DB
  • Verified agent is able to start successfully
  • Removed code for task removal during this test and replaced with a log, and observed the log during the test
  • tracked task lifecycle

New tests cover the changes: n/a

Description for the changelog

Delete containers before the task from BoltDB for proper handling of dependent data

Does this PR include breaking model changes? If so, Have you added transformation functions?

no

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.