Add AcceptInsecureCert method to AgentConfigAccessor #3940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singholt
approved these changes
Sep 29, 2023
danehlim
changed the title
prateekchaudhry
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
AcceptInsecureCertmethod toAgentConfigAccessorinterface (and to agent module's implementation of this interface). This method is required for future changes in the ecs-agent module and was missed being added as part of this previous pull request: #3928For clarity, the files that this pull request changes are not currently used by Agent in any meaningful way. These files being "plugged into power" will be done in future pull request(s) and is out of scope of this pull request.
Implementation details
AcceptInsecureCertmethod toAgentConfigAccessorinterface in ecs-agent moduleAcceptInsecureCertmethod toagentConfigAccessorstruct in agent module, which implements the above interfaceAgentConfigAccessorinterfaceTesting
Unit, integration, and functional tests.
New tests cover the changes: existing test modified to cover changes
Description for the changelog
Add AcceptInsuranceCert method to AgentConfigAccessor
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.