Implement AgentConfigAccessor interface in agent/ #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
reviewed
Sep 28, 2023
singholt
reviewed
Sep 28, 2023
danehlim
force-pushed
the
agent-config-accessor-impl
branch
from
ed43d22 to
8ad6b8e
Compare
singholt
reviewed
Sep 28, 2023
amogh09
approved these changes
Sep 28, 2023
singholt
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create struct
agentConfigAccessorin agent module that implementsAgentConfigAccessorinterface defined in ecs-agent module. The aforementioned interface was introduced in this previous pull request: #3928For clarity, this pull request adds files to the agent module but Agent does NOT currently use them in any meaningful way. These files being "plugged into power" will be done in future pull request(s) and is out of scope of this pull request.
Implementation details
agentConfigAccessorstruct toagent/config/config_accessor.gosuch thatagentConfigAccessorstruct implements theAgentConfigAccessorinterface defined in ecs-agent moduleagent/config/config_accessor_test.goTesting
Unit, integration, and functional tests.
New tests cover the changes: yes
Description for the changelog
Implement AgentConfigAccessor interface in agent/
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.