Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR bumps Golang version from 1.19.10 to
1.20.6
.Implementation details
1. Update Golang version in
BuildRequires: golang >= 1.20.0
inpackaging/amazon-linux-ami-integrated/ecs-agent.spec
to build ecs-init artifacts with the Golang version >= 1.20.0.2. Update static check tool in Makefile
Update staticcheck to
v0.4.0
to be compatible to Golang 1.20.6. See reference [here].3. Set
CGO_ENABLED=1
in scripts/run-integ-tests.ps1 to run integration test on WindowsAs Golang 1.20 now disables cgo by default on systems without a C toolchain, we need explicitly enable it. See Go 1.20 release notes [here] for more details. For reference, we got following errors before setting CGO_ENABLED=1,
Testing
New tests cover the changes: no
Description for the changelog
Enhancement - Update Agent build golang version to 1.20.6
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.