Add task stop verification ack to ecs-agent module #3820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohsoo
force-pushed
the
task_stop_verif_ack
branch
from
1880bd1 to
c2f203c
Compare
ohsoo
force-pushed
the
task_stop_verif_ack
branch
from
c2f203c to
8b557d4
Compare
danehlim
reviewed
Jul 20, 2023
agent/vendor/github.com/aws/amazon-ecs-agent/ecs-agent/acs/session/task_stop_verification_ack
Outdated
Show resolved
Hide resolved
ohsoo
force-pushed
the
task_stop_verif_ack
branch
from
8b557d4 to
14e2253
Compare
danehlim
reviewed
Jul 20, 2023
agent/vendor/github.com/aws/amazon-ecs-agent/ecs-agent/metrics/metrics.go
Show resolved
Hide resolved
ohsoo
force-pushed
the
task_stop_verif_ack
branch
2 times, most recently
from
0ccbe5e to
abedf45
Compare
danehlim
reviewed
Jul 21, 2023
danehlim
previously approved these changes
Jul 21, 2023
ohsoo
force-pushed
the
task_stop_verif_ack
branch
from
abedf45 to
b230732
Compare
danehlim
approved these changes
Jul 21, 2023
amogh09
approved these changes
Jul 21, 2023
chienhanlin
pushed a commit
that referenced
this pull request
Aug 8, 2023
* Add task stop verification ack to ecs-agent module * Add task stop verification ack to ecs-agent module
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement the ACS task stop verification ACK responder into the ecs-agent module. This is not "plugged in" to any real functionality of the agent, relevant integrations will be a follow-up.
Implementation details
New
TaskStopperinterface and taskStopVerificationACKResponder struct. Builds on top of the previously implemented task_manifest_common.gogo mod tidy && go mod vendorwas run and ended up modifying a comment in the metrics.go file as a result of a previous PR.Testing
Existing tests.
New tests cover the changes: no
Description for the changelog
Add task stop verification ack to ecs-agent module
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.