Allow variables to be set to empty string in envFiles #3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danehlim
approved these changes
Jul 15, 2023
|
Thanks for this contribution, we will take a look into it! |
amogh09
approved these changes
Jul 17, 2023
Realmonia
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We currently have environment variables set to empty such as
SIDEKIQ_PRELOAD=see issue. This works fine when passing in the variable via task definition but breaks when using environment files.Implementation details
No longer ignore variables that have an empty value.
Testing
Extended existing test to allow empty variables and confirm the variable exists in the returned map when parsing the environment file.
New tests cover the changes: yes
Description for the changelog
Allow variables to be set to the empty string when using environment files
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.