-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add daemon manager with basic instance task creation #3789
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxx0624
reviewed
Jul 10, 2023
singholt
reviewed
Jul 10, 2023
singholt
reviewed
Jul 10, 2023
singholt
reviewed
Jul 10, 2023
mye956
reviewed
Jul 11, 2023
mye956
reviewed
Jul 11, 2023
fierlion
force-pushed
the
fierlion/DaemonManager
branch
from
July 11, 2023 17:19
198d9d1
to
8cc453b
Compare
fierlion
force-pushed
the
fierlion/DaemonManager
branch
from
July 11, 2023 17:26
8cc453b
to
207cb94
Compare
mye956
approved these changes
Jul 11, 2023
singholt
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds the daemonmanager package which will be used by the Agent to create internal managed daemon tasks/containers. It also expands the managed daemon definition and setup with additional functions to create and validate the daemons.
Implementation details
Managed Daemons now have setup validation requirements in their required mount points and healthcheck. Once a daemon is successfully created, it should be registered with its own daemon manager object. This object exposes methods to create the internal managed daemon task.
Still to come are the daemon configuration and tar files (see inline TODOs in
ManagedDaemon.ImportAll()
) and also integration with the agent startup and attachment/task payload handlers to create and add the daemons to the Agent's managed task set.Note that much of this is borrowing heavily from the service connect manager: https://github.com/aws/amazon-ecs-agent/blob/master/agent/engine/serviceconnect/manager_linux.go#L299
Testing
Added new unit tests for all functions.
New tests cover the changes: Yes
Description for the changelog
Add daemon manager package with initial daemon task creation methods.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.