Move TMDS v4 container stats types to ecs-agent module #3785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
changed the title
amogh09
changed the title
amogh09
changed the title
singholt
approved these changes
Jul 6, 2023
chienhanlin
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move the following types related to container stats to ecs-agent module. The changes are required for moving TMDS v4 Task and Container Stats handlers to ecs-agent.
StatsResponse- moved fromagent/handlers/v4/stats_response.gotoecs-agent/tmds/handlers/v4/state/response.go. This is the v4 container stats response type.NetworkStatsPerSec- moved fromagent/stats/types.gotoecs-agent/stats/types.go. This type is included in TMDS v4 Stats Response.Implementation details
Testing
Automated tests only.
New tests cover the changes: no
Description for the changelog
Move TMDS v4 container stats types to ecs-agent module
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.