Move ECSTaskProtectionSDK interface to ecs-agent #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danehlim
reviewed
Jun 22, 2023
agent/vendor/github.com/aws/amazon-ecs-agent/ecs-agent/tcs/handler/handler.go
Show resolved
Hide resolved
danehlim
approved these changes
Jun 23, 2023
mythri-garaga
approved these changes
Jun 23, 2023
amogh09
force-pushed
the
move-task-protection-sdk
branch
from
305f9e5 to
b50e15a
Compare
xxx0624
pushed a commit
to xxx0624/amazon-ecs-agent
that referenced
this pull request
Jun 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moving
ECSTaskProtectionSDKinterface to ecs-agent module. The interface is only used by TMDS task scale-in protection endpoint handlers. The handlers will be moved to ecs-agent module in upcoming PRs.Note that this PR includes some changes to
agent/vendor/github.com/aws/amazon-ecs-agent/ecs-agent/tcs/handler/handler.gofile which are a result of runninggo mod vendorin agent module. The changes were added in #3731. Most likely vendor sync was not performed when this change was made inecs-agentwhich is why it's showing up on this PR. I have confirmed with the author of that PR that the changes are safe.Implementation details
ECSTaskProtectionSDKinterface fromagent/api/interface.gotoecs-agent/api/interface.go.agent/api/generate_mocks.gotoecs-agent/api/generate_mocks.go.make gogeneratefor both agent and ecs-agent modules.Testing
Automated tests only.
New tests cover the changes: no
Description for the changelog
Move ECSTaskProtectionSDK interface to ecs-agent
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.