-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more v2, v3, and v4 task metadata tests #3722
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
force-pushed
the
task-metadata-tests
branch
from
May 26, 2023 20:03
fa48172
to
15daf70
Compare
amogh09
changed the title
Add more v4 task metadata tests
Add more v2, v3, and v4 task metadata tests
May 26, 2023
mythri-garaga
previously approved these changes
May 30, 2023
mythri-garaga
approved these changes
May 30, 2023
mythri-garaga
approved these changes
May 30, 2023
Yiyuanzzz
approved these changes
May 30, 2023
This was referenced May 31, 2023
xxx0624
pushed a commit
to xxx0624/amazon-ecs-agent
that referenced
this pull request
Jun 3, 2023
Merged
This was referenced Jun 7, 2023
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation details
TestV2TaskMetadata
,TestV3TaskMetadata
, andTestV4TaskMetadata
functions for testing v2, v3, and v4 task metadata endpoints, respectively. These test functions include all happy and error cases. Remove existing tests for these endpoints as they are covered in the new test functions.Testing
New tests cover the changes: yes
Description for the changelog
Add more v2, v3, and v4 task metadata tests
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.