Refresh handler gmsa linux #3709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikiranakula-amzn
changed the base branch from
master
to
feature/ecs-domainless-gmsa
saikiranakula-amzn
force-pushed
the
refresh_handler_gmsa_linux
branch
from
b1e4cde to
11b210d
Compare
amogh09
reviewed
May 25, 2023
amogh09
approved these changes
May 25, 2023
arun-annamalai
approved these changes
May 25, 2023
| @@ -3019,7 +3019,7 @@ func (task *Task) GetCredentialSpecResource() ([]taskresource.TaskResource, bool | |||
| } | |||
|
|
|||
| // getAllCredentialSpecRequirements is used to build all the credential spec requirements for the task | |||
There was a problem hiding this comment.
super nit: comment also needs to be update to GetAllCredentialSpecRequirements.
mythri-garaga
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refreshes the kerberos ticket associated to gMSA account on Linux
Implementation details
Testing
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.