Refresh Windows Domainless gMSA plugin credentials #3703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythri-garaga
previously approved these changes
May 18, 2023
amogh09
reviewed
May 18, 2023
arun-annamalai
force-pushed
the
refresh3
branch
5 times, most recently
from
bcb1af2 to
928e7ad
Compare
amogh09
reviewed
May 18, 2023
arun-annamalai
force-pushed
the
refresh3
branch
2 times, most recently
from
ca83200 to
6147190
Compare
amogh09
reviewed
May 18, 2023
arun-annamalai
force-pushed
the
refresh3
branch
2 times, most recently
from
bd9f9c6 to
501b3e1
Compare
amogh09
approved these changes
May 19, 2023
mythri-garaga
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The domainless gMSA plugin requires taskExecutionRole IAM credentials to access customer resources. These credentials are populated once at the beginning of task start, but they need to be updated each time the credentials are vended down to the agent.
Implementation details
This change is primarily implemented in the refresh handler. Everytime an execution role gets vended down, the refresh handler should populate the Windows registry key where the plugin credentials are stored.
Testing
This change was unit tested
I have also let a task run for 2 days and then checked out the instance logs and I do see that the credentials are being set correctly after a refresh from ACS (have logs I can send)
New tests cover the changes:
yes
Description for the changelog
Refresh Windows Domainless gMSA plugin credentials
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.