Move credentials endpoints to ecs-agent module #3698
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move v1 and v2 TMDS credentials endpoint handlers from agent module to ecs-agent module.
Implementation details
agent/handlers/v1/credentials_handler.go
toecs-agent/tmds/handlers/v1/credentials_handler.go
.agent/handlers/v2/credentials_handler.go
toecs-agent/tmds/handlers/v2/credentials_handler.go
.GetCredentialsEventType
function fromagent/logger/audit/entry_types.go
toecs-agent/logger/audit/audit_log.go
. This function returns an appropriate audit log event type for the provided role type (task role or execution role) and is used by credentials endpoint handlers too. Also moved the corresponding audit log event type constants that this function returns.ZeroOrNil
util function fromagent/utils/utils.go
toecs-agent/utils/utils.go
as it is used by credentials handlers.Testing
In addition to new unit tests, also performed manual stress testing for the two changed endpoints. There is no obvious change in performance seen.
New tests cover the changes: yes
Description for the changelog
Move v1 and v2 TMDS credentials endpoints to ecs-agent module.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.