Add gMSA domainless support #3689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikiranakula-amzn
force-pushed
the
gmsa_linux_domainless_capability
branch
2 times, most recently
from
fc3b601 to
739ab65
Compare
saikiranakula-amzn
requested review from
amogh09,
arun-annamalai,
mythri-garaga and
yinyic
saikiranakula-amzn
force-pushed
the
gmsa_linux_domainless_capability
branch
from
739ab65 to
2ad26fb
Compare
amogh09
reviewed
May 12, 2023
saikiranakula-amzn
force-pushed
the
gmsa_linux_domainless_capability
branch
4 times, most recently
from
2d861ef to
3b1bed0
Compare
arun-annamalai
previously approved these changes
May 15, 2023
amogh09
reviewed
May 15, 2023
saikiranakula-amzn
force-pushed
the
gmsa_linux_domainless_capability
branch
2 times, most recently
from
3cb9518 to
096f9c6
Compare
saikiranakula-amzn
force-pushed
the
gmsa_linux_domainless_capability
branch
from
70be52a to
74d2abb
Compare
amogh09
approved these changes
May 15, 2023
mythri-garaga
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the domainless gMSA support on linux establishing communication with credentials-fetcher daemon and also sharing tickets with application containers
Implementation details
Added gMSA linux domainless support
Testing
This was tested through unit tests, as well as manually running the agent on the instance and also verifying the gMSA domainless functionality
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.