Inject domainless gmsa cred spec into Windows Container #3682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arun-annamalai
changed the title
jterry75
reviewed
May 9, 2023
jterry75
reviewed
May 9, 2023
jterry75
reviewed
May 9, 2023
jterry75
reviewed
May 9, 2023
jterry75
reviewed
May 9, 2023
arun-annamalai
changed the title
arun-annamalai
force-pushed
the
windows_injection2
branch
from
1dd3c09 to
113ac0d
Compare
amogh09
reviewed
May 11, 2023
amogh09
reviewed
May 11, 2023
amogh09
reviewed
May 11, 2023
amogh09
reviewed
May 11, 2023
amogh09
reviewed
May 11, 2023
amogh09
reviewed
May 11, 2023
amogh09
reviewed
May 11, 2023
amogh09
reviewed
May 11, 2023
jterry75
reviewed
May 11, 2023
jterry75
reviewed
May 11, 2023
jterry75
reviewed
May 11, 2023
jterry75
reviewed
May 11, 2023
arun-annamalai
force-pushed
the
windows_injection2
branch
2 times, most recently
from
bc0f373 to
8d88030
Compare
arun-annamalai
changed the title
mythri-garaga
previously approved these changes
May 15, 2023
arun-annamalai
force-pushed
the
windows_injection2
branch
from
8d88030 to
87e5301
Compare
amogh09
reviewed
May 15, 2023
agent/taskresource/credentialspec/credentialspec_windows_test.go
Outdated
Show resolved
Hide resolved
| err := cs.handleSSMCredentialspecFile(ssmCredentialSpec, credentialSpecSSMARN, iamCredentials) | ||
| assert.NoError(t, err) | ||
| for _, tc := range testCases { | ||
| t.Run(tc.name, func(t *testing.T) { |
There was a problem hiding this comment.
[Not required in this PR] I think there is a lot of room to break down the credentialspec package into smaller units and test them individually. The package is juggling way too many responsibilities in its current state. The amount of set up in this test function is staggering.
There was a problem hiding this comment.
Will bring this up with WCT team and plan for a refactor
arun-annamalai
force-pushed
the
windows_injection2
branch
4 times, most recently
from
b628b25 to
404f9c3
Compare
arun-annamalai
force-pushed
the
windows_injection2
branch
3 times, most recently
from
1659233 to
cf402c1
Compare
amogh09
approved these changes
May 16, 2023
mythri-garaga
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request injects the domainless gMSA cred spec into the Windows container runtime (docker). It also sets the plugin execution role credentials for the domainless gMSA plugin to use.
Implementation details
Domainless gMSA requires a pluginInput field in the credential spec to be populated. This change parses in the customer JSON, and modifies the pluginInput to point to the correct registry key that holds the task execution role credentials. It also sets the task execution role credentials to the aforementioned registry key.
Testing
These changes are unit tests and also manually tested by running a domainless task on a EC2 instance that is registered against gamma.
New tests cover the changes:
yes
Description for the changelog
Inject domainless gmsa cred spec into Windows Container
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.