Domainless gMSA linux capability and gRPC endpoints #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikiranakula-amzn
force-pushed
the
gmsa_linux_domainless_capability
branch
2 times, most recently
from
108f5b4 to
7175a90
Compare
saikiranakula-amzn
requested review from
arun-annamalai,
yinyic,
mythri-garaga,
chienhanlin and
amogh09
arun-annamalai
previously approved these changes
May 8, 2023
|
Hello. Can you please comment out |
mythri-garaga
previously approved these changes
May 9, 2023
amogh09
requested changes
May 9, 2023
amogh09
reviewed
May 9, 2023
saikiranakula-amzn
dismissed stale reviews from mythri-garaga and arun-annamalai
via
3b61e2a
saikiranakula-amzn
force-pushed
the
gmsa_linux_domainless_capability
branch
from
8fa37d5 to
3b61e2a
Compare
1. Added gMSA linux domainless capbility 2. gRPC endpoint
amogh09
reviewed
May 9, 2023
saikiranakula-amzn
force-pushed
the
gmsa_linux_domainless_capability
branch
from
3b61e2a to
451ea59
Compare
amogh09
approved these changes
May 9, 2023
mythri-garaga
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the agent advertisement capability for domainless gMSA support on linux and also updated the gRPC endpoints for domainless communication with credentials-fetcher daemon
Implementation details
Testing
This was tested through unit tests, as well as manually running the agent on the instance and also verifying the agent capability for domainless gMSA support.
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.