Plumb credentialSpecs field into container #3675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arun-annamalai
requested review from
amogh09,
mythri-garaga,
saikiranakula-amzn and
yinyic
saikiranakula-amzn
previously approved these changes
May 5, 2023
amogh09
reviewed
May 5, 2023
arun-annamalai
force-pushed
the
plumbing_container
branch
from
6618154 to
edd5a77
Compare
amogh09
approved these changes
May 5, 2023
mythri-garaga
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the credentialSpecs field into the agent container object, and then modifies the getCredentialSpec function to look in the credentialSpecs field when attempting to retrieve any credentialSpecs associated with the container.
Implementation details
The changes to getCredentialSpec() are implemented in the following
Testing
This was tested through unit tests, as well as manually running the agent on the instance, calling run-task with a domainless gMSA task, and printing out the contents of the container object.
New tests cover the changes: yes
Description for the changelog
Plumb credentialSpecs field into container
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.