Move container instance health doctor to ecs-agent/

[danehlim]

Summary

Move doctor (container instance health) to ecs-agent/ and reformat accordingly.

NOTE: An interface for logging to be used in ecs-agent/ will be added as part of a future PR and is out of scope of this PR. For now, we continue to leverage our existing dependency on seelog in the ecs-agent module.

Implementation details

• Move agent/doctor/doctor.go, agent/doctor/doctor_test.go, agent/doctor/healthcheck.go, agent/doctor/healthcheckstatus.go, and agent/doctor/healthcheckstatus_test.go to ecs-agent/doctor/ directory
• Replace all imports of github.com/aws/amazon-ecs-agent/agent/doctor with github.com/aws/amazon-ecs-agent/ecs-agent/doctor and then resort imports
• For files that previously imported github.com/aws/amazon-ecs-agent/agent/doctor but still have a dependency on agent/doctor/docker_runtime_healthcheck.go, reimport github.com/aws/amazon-ecs-agent/agent/doctor with alias dockerdoctor (to avoid package name conflict with github.com/aws/amazon-ecs-agent/ecs-agent/doctor)
  • github.com/aws/amazon-ecs-agent/ecs-agent/doctor is for general container instance health check functionality and constants
  • github.com/aws/amazon-ecs-agent/agent/doctor is for container instance health check things that are specific to our Agent, such as Docker health checks (since our Agent is Docker based)
• Update doctor tests to use correct expected and actual values for assertions
• Update health check status tests to use assert package for assertions
• Go into agent/ directory and run go mod tidy and go mod vendor
• Go into ecs-agent/ directory and run go mod tidy and go mod vendor

Testing

Unit, integration, and functional tests.

Description for the changelog

Move container instance health doctor to ecs-agent/

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[amogh09]

LGTM overall. Left a couple of minor comments.

[YashdalfTheGray]

Code looks good, thanks for making the updates.