Update docker client library to v23.0.3 in ecs-init #3635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythri-garaga
force-pushed
the
ecs-init-docker-update
branch
from
24084ca to
159c50a
Compare
mythri-garaga
commented
Apr 10, 2023
| @@ -46,5 +49,3 @@ replace github.com/coreos/go-systemd => github.com/coreos/go-systemd/v22 v22.0.0 | |||
| replace golang.org/x/net => golang.org/x/net v0.0.0-20170529214944-3da985ce5951 | |||
|
|
|||
| replace github.com/jmespath/go-jmespath => github.com/jmespath/go-jmespath v0.0.0-20180206201540-c2b33e8439af | |||
|
|
|||
| replace github.com/pkg/errors => github.com/pkg/errors v0.8.1-0.20170505043639-c605e284fe17 | |||
There was a problem hiding this comment.
removed this line as tests were failing with
go test -count=1 -short -v -coverprofile cover.out ./ecs-init/...
# github.com/aws/amazon-ecs-agent/ecs-init/vendor/github.com/docker/docker/pkg/archive
ecs-init/vendor/github.com/docker/docker/pkg/archive/archive.go:782:14: undefined: errors.Is
Realmonia
previously approved these changes
Apr 10, 2023
Yiyuanzzz
previously approved these changes
Apr 10, 2023
YashdalfTheGray
previously approved these changes
Apr 10, 2023
|
Locally ran functional tests for al2023, al2023arm and al2023neu and they succeeded. |
mythri-garaga
dismissed stale reviews from YashdalfTheGray, Yiyuanzzz, and Realmonia
via
e808ee5
mythri-garaga
force-pushed
the
ecs-init-docker-update
branch
from
159c50a to
e808ee5
Compare
|
rebased to include the fix #3638. |
Yiyuanzzz
approved these changes
Apr 14, 2023
YashdalfTheGray
approved these changes
Apr 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have a dependabot PR #3633 open to update docker client in ecs-init from 20.10.3-0.20210618090124-472f21b923ef+incompatible to 20.10.24+incompatible. The dependabot PR is failing with
and upon trying to resolve the case-insensitive import collision, there was another error while running linux tests
So this PR updates the docker client library to v23.0.3(latest version) in ecs-init to avoid the above failures
Implementation details
Testing
New tests cover the changes:
Description for the changelog
Enhancement: update docker client library to latest in ecs-init
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.