Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs-init: Add ISO partition for downloading agent appropriately #3630

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

singholt
Copy link
Contributor

@singholt singholt commented Mar 31, 2023

Summary

This PR adds the ISO partition ID and the region to the partitionBucketRegion mapping. ECS init goes looking for where to download ecs agent from, but fails for ISO regions. With this change, it should now be able to look in the right place.

Implementation details

We use the identifier defined in aws-sdk:

const (
AwsPartitionID = "aws" // AWS Standard partition.
AwsCnPartitionID = "aws-cn" // AWS China partition.
AwsUsGovPartitionID = "aws-us-gov" // AWS GovCloud (US) partition.
AwsIsoPartitionID = "aws-iso" // AWS ISO (US) partition.
AwsIsoBPartitionID = "aws-iso-b" // AWS ISOB (US) partition.
)

Testing

New tests cover the changes: no

Description for the changelog

Fix: Add ISO partition for downloading agent appropriately

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@singholt singholt requested a review from a team as a code owner March 31, 2023 22:01
@singholt singholt changed the base branch from master to dev March 31, 2023 22:01
@Realmonia
Copy link
Contributor

Realmonia commented Mar 31, 2023

What's the use case of this change? (specifically when does this happen?)

ECS init goes looking for where to download ecs agent from, but fails for ISO regions.

Nvm I see the thread on slack. Can we also make sure the S3 url in ISO is the same as that of commercial regions?

@singholt
Copy link
Contributor Author

What's the use case of this change? (specifically when does this happen?)

ECS init goes looking for where to download ecs agent from, but fails for ISO regions.

Nvm I see the thread on slack. Can we also make sure the S3 url in ISO is the same as that of commercial regions?

yes I'll work with the engineer assisting us to test this and verify before merging.

Copy link
Contributor

@YashdalfTheGray YashdalfTheGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These exist in the SDK, so we're good to go here.

@singholt
Copy link
Contributor Author

singholt commented Apr 4, 2023

What's the use case of this change? (specifically when does this happen?)

ECS init goes looking for where to download ecs agent from, but fails for ISO regions.

Nvm I see the thread on slack. Can we also make sure the S3 url in ISO is the same as that of commercial regions?

yes I'll work with the engineer assisting us to test this and verify before merging.

verified this fixes the error (logged as a warning in ecs init logs). Merging.

@singholt singholt merged commit 6a3412a into aws:dev Apr 4, 2023
This was referenced Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants