Read git hash from RELEASE_COMMIT file if possible #3508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Read git hash from RELEASE_COMMIT file if possible
Implementation details
gitHash()
function inversion-gen.go
, try to read hash fromRELEASE_COMMIT
file instead using newreleaseCommitGitHash()
functiongitHash()
andreleaseCommitGitHash()
functions inversion-gen.go
RELEASE_COMMIT
file toamazon-linux-sources.tgz
inMakefile
os.ReadFile
instead ofioutil.ReadFile
inversion-gen.go
since ioutil package is deprecated as of Go 1.16Testing
In the repo root, create a test
RELEASE_COMMIT
file, run version-gen.go, and verify that the correct hash is obtained.New tests cover the changes: no
Description for the changelog
Read git hash from RELEASE_COMMIT file if possible
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.